Use proper prototypes in struct boot_module_t
ClosedPublic

Authored by dim on Jan 11 2017, 7:44 PM.

Details

Summary

With clang 4.0.0, we are getting the following warnings about struct
boot_module_t in efi's boot_module.h:

In file included from sys/boot/efi/boot1/ufs_module.c:41:
sys/boot/efi/boot1/boot_module.h:67:14: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
        void (*init)();
                    ^
                     void
sys/boot/efi/boot1/boot_module.h:92:16: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
        void (*status)();
                      ^
                       void
sys/boot/efi/boot1/boot_module.h:95:24: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
        dev_info_t *(*devices)();
                              ^
                               void
3 errors generated.

Fix this by adding 'void' to the parameter lists. No functional change.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dim retitled this revision from to Use proper prototypes in struct boot_module_t.Jan 11 2017, 7:44 PM
dim updated this object.
dim edited the test plan for this revision. (Show Details)
dim added reviewers: emaste, smh.
emaste accepted this revision.Jan 11 2017, 7:49 PM
This revision is now accepted and ready to land.Jan 11 2017, 7:49 PM
imp accepted this revision.Jan 11 2017, 7:50 PM
imp added a reviewer: imp.
smh accepted this revision.Jan 11 2017, 7:50 PM
This revision was automatically updated to reflect the committed changes.