[NEW PORT] www/miniminiweb
ClosedPublic
Actions

Authored by ler on Jan 11 2017, 2:51 AM.

Details

Reviewers

adamw
rene

Commits

rP431156: New Port www/miniminiweb

Summary

New Port www/miniminiweb

MiniMiniWeb is my attempt at creating a multithreaded web server in C.

Features (and Misfeatures)

Written in C
Multithreaded (with pthread)
Designed for Unix-like systems
Supports GET and POST requests
Only serves static files
No SSL
No CGI or anything "dynamic"
No Virtual Hosts
No Directory Listings (gotten pulled out)
No IPv6

PR: 211472
Submiited by: neel@neelc.org
Approved by: adamw (mentor)

Test Plan

portlint -Ac (OK)
poudriere test port (ok)
make describe
borg.lerctr.org ~/FreeBSD/ports/www/miniminiweb $ make describe
miniminiweb-0.0.2|/home/ler/FreeBSD/ports/www/miniminiweb|/usr/local|Minimal, Multithreaded web server in C|/home/ler/FreeBSD/ports/www/miniminiweb/pkg-descr|neel@neelc.org|www||||||https://www.github.com/neelchauhan/MiniMiniWeb
borg.lerctr.org ~/FreeBSD/ports/www/miniminiweb $

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ler updated this revision to Diff 23862.Jan 11 2017, 2:51 AM

ler retitled this revision from to [NEW PORT] www/miniminiweb.

ler updated this object.

ler edited the test plan for this revision. (Show Details)

ler added reviewers: adamw, rene.

ler set the repository for this revision to rP FreeBSD ports repository.

Herald added a subscriber: mat. · View Herald TranscriptJan 11 2017, 2:51 AM

remove it's not line from pkg-descr

Looks good. Go for it.

Also remove the "It's not" sentence from the commit message, and check the spelling on "Submitted by"

This revision is now accepted and ready to land.Jan 11 2017, 2:57 AM

remove custom do-install target -- it's the standard.

This revision now requires review to proceed.Jan 11 2017, 2:58 AM

ler updated this object.Jan 11 2017, 2:59 AM

ler edited edge metadata.

adamw accepted this revision.Jan 11 2017, 3:02 AM

adamw edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2017, 3:02 AM

Closed by commit rP431156: New Port www/miniminiweb (authored by ler). · Explain WhyJan 11 2017, 3:05 AM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Jan 11 2017, 2:31 PM

head/www/miniminiweb/Makefile
3	Portname should be MiniMiniWeb. The only case where you are allowed to not respect upstream's case is when, say, upstream says it is LSoF, and it installs a binary called "lsof". In this case, if it installed bin/miniminiweb it'd be ok, but it actually installs bin/MiniMiniWeb

Larry, Mat's right here and we should do this.

Have a look through https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-repocopies when you have some time and type up a plan for the svn commands and edits that you expect to issue to accomplish this.

should I open a new differential for that? or put the commands here?

In D9127#188787, @ler wrote:

should I open a new differential for that? or put the commands here?

Here's fine.

svn up
svn move www/miniminiweb www/MiniMiniWeb
edit www/Makefile to reflect the name change
edit Moved to reflect the name change
www/miniminiweb|www/MiniMiniWeb|2017-01-11|change case name per standards
edit www/MiniMiniWeb/Makefile portname

Those steps look good, Larry. Before we do this, though, I think that you should send Neel an email (Cc: me and Rene please) and ask him whether he wants us to rename the port, or install the binary as miniminiweb. Neel tends to be pretty responsive. Also, suggest to him that it'd be easier to deploy mmw if the port had an rc(8) script.