pr 214722
ClosedPublic
Actions

Authored by ler on Jan 11 2017, 1:10 AM.

Details

Reviewers

adamw
rene

Commits

rP431152: Use milter framework to handle libmilter correctly

Summary

Use milter framework to handle libmilter correctly
updated pkg-plist to use @sample, and changed SMF_RUN_DIR to be substituted
in the pkg-plist. Bumped PORTREVISION

PR: 214722
Submitted by: sasaki@fcc.ad.jp (maintainer)
Approved by: adamw (mentor)

Test Plan

poudriere testport (ok)
portlint -aC (ok) -- warnings about make makepatch

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ler updated this revision to Diff 23858.Jan 11 2017, 1:10 AM

ler retitled this revision from to pr 214722.

ler updated this object.

ler edited the test plan for this revision. (Show Details)

ler added reviewers: adamw, rene.

ler set the repository for this revision to rP FreeBSD ports repository.

Herald added a subscriber: mat. · View Herald TranscriptJan 11 2017, 1:10 AM

ler updated this object.Jan 11 2017, 1:11 AM

What is with the SMFSAV_RUN_DIR variable? It's not in the plist, so the port will break if it's changed from the original.

Also the smfsav.conf.sample should be @sample in the plist.

that was there and not touched by this patch.

In D9126#188626, @ler wrote:

that was there and not touched by this patch.

Yes, and the submitter doesn't know it's wrong because a committer hasn't shown him the right way to do it. You should fix everything wrong you can find, and when you close the PR you should tell the submitter the changes you made so that he can learn from them.

take adamw's suggestions. Bump portrevision

Patch looks good, but don't put a note to the maintainer in the commit message. Let the commit message describe what you've changed and why. The note to the maintainer should be in the PR.

ler updated this object.Jan 11 2017, 1:47 AM