Update KDevelop to 4.7.3

[adridg]

Summary

This updates the KDevelop port (and kdevplatform) for KDE4
to the latest version 4.7.3. Drops some patches previously
pulled from git, adds new ones.

Test Plan

The other kdevelop ports (-pg-qt and similar) need to be built.

[adridg]

kdevelop-php also new distfile.

[adridg]

Third time's the charm: also update kdevelop-php-docs

[tcberner]

Mk/Uses/kde.mk

82 ↗

(On Diff #23482)

I think we should drop this from kde.mk and define it in the ports themselves directly.

[tcberner]

There are plist-issues in devel/kdevelop-php-docs

[adridg]

Update patch (4)

• Removed kdevelop and kdevplatform versions from kde.mk, placed in a Makefile.common.
• Add %%NLS%% substitution to kdevelop-php-docs plist.
• (TODO?) Perhaps more things like MASTER_SITES could be set there.
• (TODO?) Is .include right there at the top of the makefile the right thing to do?

[adridg]

Also note that the whole review mentions the wrong version: this update is from 4.7.3 -> 4.7.4

[rakuco]

Mk/Uses/kde.mk

82 ↗

(On Diff #23482)

I think we should drop this from kde.mk and define it in the ports themselves directly.

Can you explain why?

devel/kdevplatform/files/patch-cmake__modules__KDevPlatformMacros_cmake.patch

1 ↗

(On Diff #23517)

Compared to https://cgit.kde.org/kdevplatform.git/commit/?id=46c2d324f7ed8e36331b02a179113c5a545e3280 and https://cgit.kde.org/kdevplatform.git/commit/?id=fb6cdad82ec2e014faec7a2b46151c1981547698, upstream is missing --uname and --gname. Can you send a patch to kdevplatform?

[tcberner]

Mk/Uses/kde.mk

82 ↗

(On Diff #23482)

I don't see much benefit in it being defined in kde.mk -- I think we should only have KDE4/Frameworks/Plasma/Applications numbers in there, the stuff that actually is handled by kde.mk.

So CALLIGRA and KTP versions should be kicked too -- or DIGIKAM added :P

But don't let that be the hold up.

[tcberner]

devel/kdevelop-kde4/Makefile

4 ↗

(On Diff #23517)

If the choice is between having Makefile.common and defining the version in kde.mk, then I want kde.mk :)

[adridg]

• Moved version number back to kde.mk
• Fixed remaining plist issues with NLS

[tcberner]

Should be fine now -- sorry for the hassle.

[adridg]

devel/kdevelop-kde4/Makefile

4 ↗

(On Diff #23517)

Since digikam had a Makefile.common -- for its family of ports -- and similarly kde-l10n and kdegames4, I figured it was a standard way of doing "all these ports belong together and need to be updated in lock-step". Apparently not.

devel/kdevplatform/files/patch-cmake__modules__KDevPlatformMacros_cmake.patch

1 ↗

(On Diff #23517)

That'll go in a KDE Phab review; I'll add you as observer for it.