Differential D8917

security/py-fail2ban: Update to 0.9.6
ClosedPublic
Actions

Authored by lifanov on Dec 26 2016, 4:50 PM.

Details

Reviewers

matthew

Commits

rP429667: Update fail2ban to version 0.9.6

Summary

Update fail2ban to version 0.9.6

Bugzilla: 215239
Submitted by: John W. O'Brien <john@saltant.com>
Reviewed by: matthew
Approved by: theis@gmx.at (maintainer), matthew (mentor)
Differential revision: https://reviews.freebsd.org/D8917

Test Plan

portlint: OK (no new warnings)
poudriere: OK (10.3R amd64 with py27, py34, py35)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lifanov updated this revision to Diff 23279.Dec 26 2016, 4:50 PM

lifanov retitled this revision from to security/py-fail2ban: Update to 0.9.6.

lifanov updated this object.

lifanov edited the test plan for this revision. (Show Details)

lifanov added a reviewer: matthew.

lifanov added a subscriber: koobs.

Herald added a subscriber: mat. · View Herald TranscriptDec 26 2016, 4:50 PM

lifanov updated this object.Dec 26 2016, 4:53 PM

matthew added inline comments.Dec 26 2016, 10:00 PM

security/py-fail2ban/files/patch-setup.py
31 ↗	(On Diff #23279)	Hard-coding '/usr/local' as the value of $LOCALBASE should be avoided. One approach is to insert a token like %%LOCALBASE%% via patch files, and then substitute in the value of $LOCALBASE by using ${REINPLACE_CMD} in post-patch:

Hmmm... PR 215239 has been closed as a duplicate of PR 215354. I'd only mention 215354 in the commit log.

matthew added inline comments.Dec 27 2016, 9:50 AM

security/py-fail2ban/files/patch-setup.py

31 ↗

(On Diff #23279)

Also: /usr/local/usr/local -- that's clearly wrong, which is reflected in the
poudriere output:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: @dir %%ETCDIR%%
Error: Orphaned: @dir usr/local/usr/local/%%ETCDIR%%/fail2ban.d
Error: Orphaned: @dir usr/local/usr/local/%%ETCDIR%%/jail.d
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: @dir %%ETCDIR%%/fail2ban.d
Error: Missing: @dir %%ETCDIR%%/jail.d
===> Error: Plist issues found.
*** [check-plist] Error code 1

OK, cool, thanks! I'll figure it out with the maintainer. The duplicate situation is that he said that he attached what was an identical patch to his PR, so I would like to give credit to the other submitter as well.

lifanov updated this object.Dec 27 2016, 2:45 PM

lifanov edited edge metadata.

In D8917#184674, @lifanov wrote:

OK, cool, thanks! I'll figure it out with the maintainer. The duplicate situation is that he said that he attached what was an identical patch to his PR, so I would like to give credit to the other submitter as well.

You've mentioned his name in 'Submitted by' -- that should be fine.

address matthew's feedback by using John W. O'Brien's version instead

Maintainer approved both submissions and this is the one that was
tested. I verified it myself and it works and plist is clean.

inline comments addressed using a different patch

In D8917#184680, @lifanov wrote:

address matthew's feedback by using John W. O'Brien's version instead

Maintainer approved both submissions and this is the one that was
tested. I verified it myself and it works and plist is clean.

Yeah. Always test things yourself.

Yep, will do going forward.