Page MenuHomeFreeBSD

Qt5: Drop post-configure target from most QT_DIST ports
ClosedPublic

Authored by rakuco on Dec 24 2016, 5:55 PM.

Details

Summary

Qt's configure script already creates all the necessary Makefiles for the directories we need to build, so there is no need to run qmake again in post-configure.

Test Plan

Tested the ports on Poudriere (9.3-i386 and 12-amd64) and everything worked fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rakuco updated this revision to Diff 23240.Dec 24 2016, 5:55 PM
rakuco retitled this revision from to Qt5: Drop post-configure target from most QT_DIST ports.
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added reviewers: kde, tcberner, adridg.
rakuco set the repository for this revision to rP FreeBSD ports repository.
adridg edited edge metadata.Dec 24 2016, 8:21 PM

Tested qt5-network on 10.3-x64. It's ok; there are some stage-qa warnings, but those aren't related to this review.

Tested qt5-printsupport on 10.3-x64, with and without option CUPS. It's ok; same stage-qa warnings.

adridg accepted this revision.Dec 24 2016, 8:27 PM
adridg edited edge metadata.

Tested qt5-buildtools on 10.3-x64 and dbus-qt5 on 10.3-x64, they're OK.

This revision is now accepted and ready to land.Dec 24 2016, 8:27 PM
tcberner accepted this revision.Dec 25 2016, 10:58 PM
tcberner edited edge metadata.

There seems to be a difference in the Makefiles with and without the target (for example in dbus-qt5's src/tools/qdbusxml2cpp) -- but it still seems to work as expected.

This revision was automatically updated to reflect the committed changes.