ATFify the geom gate tests.

[asomers]

Summary

ATFify the geom gate tests.

This ensures their cleanup routines will be run even if they should timeout.

tests/sys/geom/class/gate/ggate_test.sh
tests/sys/geom/class/gate/Makefile
Add an ATF test with three testcases, one for each TAP test. Use
ATF-style cleanup functions, and convert sleeps to polling loops.

tests/sys/geom/class/gate/conf.sh
tests/sys/geom/class/gate/1_test.sh
tests/sys/geom/class/gate/2_test.sh
tests/sys/geom/class/gate/3_test.sh
Delete TAP test files

Test Plan

Run the tests 1000 times

[ngie]

Thank you for doing this!

tests/sys/geom/class/gate/ggate_test.sh

7

*RETRIES

80

Wouldn't common_cleanup handle this because they've been accounted for already in PLAINFILES?

108

No conv=sync?

156–158

Could you please dump out the checksums for debugging purposes (they should remain consistent if the input from /dev/random is consistent)?

162

Same here.

[asomers]

tests/sys/geom/class/gate/ggate_test.sh

80

Yeah, you're right.

108

It wasn't in the original 2_test.sh. And come to think of it, it probably shouldn't be anywhere. It doesn't make sense for an endless input stream like /dev/random. I should probably put conv=notrunc everywhere, though, since we're working with raw block devices.

156–158

Why would /dev/random's output ever be consistent?

[asomers]

Respond to ngie's comments