Page MenuHomeFreeBSD

ATFify the geom gate tests.
ClosedPublic

Authored by asomers on Dec 23 2016, 12:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 2:25 PM
Unknown Object (File)
Jan 23 2024, 12:07 PM
Unknown Object (File)
Dec 29 2023, 5:09 PM
Unknown Object (File)
Nov 11 2023, 7:42 PM
Unknown Object (File)
Nov 7 2023, 9:54 PM
Unknown Object (File)
Nov 6 2023, 3:41 AM
Unknown Object (File)
Oct 8 2023, 6:34 PM
Unknown Object (File)
Oct 6 2023, 8:49 PM
Subscribers

Details

Summary

ATFify the geom gate tests.

This ensures their cleanup routines will be run even if they should timeout.

tests/sys/geom/class/gate/ggate_test.sh
tests/sys/geom/class/gate/Makefile
Add an ATF test with three testcases, one for each TAP test. Use
ATF-style cleanup functions, and convert sleeps to polling loops.

tests/sys/geom/class/gate/conf.sh
tests/sys/geom/class/gate/1_test.sh
tests/sys/geom/class/gate/2_test.sh
tests/sys/geom/class/gate/3_test.sh
Delete TAP test files

Test Plan

Run the tests 1000 times

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers retitled this revision from to ATFify the geom gate tests..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: ngie.

Thank you for doing this!

tests/sys/geom/class/gate/ggate_test.sh
7 ↗(On Diff #23211)

*RETRIES

80 ↗(On Diff #23211)

Wouldn't common_cleanup handle this because they've been accounted for already in PLAINFILES?

108 ↗(On Diff #23211)

No conv=sync?

156–158 ↗(On Diff #23211)

Could you please dump out the checksums for debugging purposes (they should remain consistent if the input from /dev/random is consistent)?

162 ↗(On Diff #23211)

Same here.

tests/sys/geom/class/gate/ggate_test.sh
80 ↗(On Diff #23211)

Yeah, you're right.

108 ↗(On Diff #23211)

It wasn't in the original 2_test.sh. And come to think of it, it probably shouldn't be anywhere. It doesn't make sense for an endless input stream like /dev/random. I should probably put conv=notrunc everywhere, though, since we're working with raw block devices.

156–158 ↗(On Diff #23211)

Why would /dev/random's output ever be consistent?

asomers edited edge metadata.

Respond to ngie's comments

ngie edited edge metadata.
This revision is now accepted and ready to land.Jan 7 2017, 10:36 AM
This revision was automatically updated to reflect the committed changes.