ATFify the geom gate tests.
ClosedPublic
Actions

Authored by asomers on Dec 23 2016, 12:09 AM.

Details

Reviewers

ngie

Commits

rS311893: ATFify the geom gate tests.

Summary

ATFify the geom gate tests.

This ensures their cleanup routines will be run even if they should timeout.

tests/sys/geom/class/gate/ggate_test.sh
tests/sys/geom/class/gate/Makefile
Add an ATF test with three testcases, one for each TAP test. Use
ATF-style cleanup functions, and convert sleeps to polling loops.

tests/sys/geom/class/gate/conf.sh
tests/sys/geom/class/gate/1_test.sh
tests/sys/geom/class/gate/2_test.sh
tests/sys/geom/class/gate/3_test.sh
Delete TAP test files

Test Plan

Run the tests 1000 times

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 23211.Dec 23 2016, 12:09 AM

asomers retitled this revision from to ATFify the geom gate tests..

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added a reviewer: ngie.

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2016, 12:09 AM

Thank you for doing this!

tests/sys/geom/class/gate/ggate_test.sh
7 ↗	(On Diff #23211)	*RETRIES
80 ↗	(On Diff #23211)	Wouldn't common_cleanup handle this because they've been accounted for already in PLAINFILES?
108 ↗	(On Diff #23211)	No `conv=sync`?
156–158 ↗	(On Diff #23211)	Could you please dump out the checksums for debugging purposes (they should remain consistent if the input from /dev/random is consistent)?
162 ↗	(On Diff #23211)	Same here.

asomers added inline comments.Dec 23 2016, 3:28 AM

tests/sys/geom/class/gate/ggate_test.sh
80 ↗	(On Diff #23211)	Yeah, you're right.
108 ↗	(On Diff #23211)	It wasn't in the original 2_test.sh. And come to think of it, it probably shouldn't be anywhere. It doesn't make sense for an endless input stream like /dev/random. I should probably put conv=notrunc everywhere, though, since we're working with raw block devices.
156–158 ↗	(On Diff #23211)	Why would /dev/random's output ever be consistent?