Page MenuHomeFreeBSD

New port: devel/go-errors
AbandonedPublic

Authored by sbz on Dec 18 2016, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 6:26 AM
Unknown Object (File)
Sat, Apr 13, 3:45 AM
Unknown Object (File)
Sat, Apr 13, 3:44 AM
Unknown Object (File)
Sat, Apr 13, 3:42 AM
Unknown Object (File)
Sat, Apr 13, 3:42 AM
Unknown Object (File)
Sat, Apr 13, 3:42 AM
Unknown Object (File)
Sat, Apr 13, 2:03 AM
Unknown Object (File)
Mar 10 2024, 6:55 AM
Subscribers

Details

Reviewers
jlaffaye
mat
Summary

Package errors provides simple error handling primitives for Go.

WWW: https://github.com/pkg/errors

Test Plan
  • portlint -a
  • poudriere testport -j 11i386 -p portsdir -o devel/go-errors [1]
  • poudriere testport -j 11amd64 -p portsdir -o devel/go-errors [2]

[1] http://62.210.142.226:8000/11i386-portsdir/latest/build.html
[2] http://62.210.142.226:8000/11amd64-portsdir/latest/build.html

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6308
Build 6548: arc lint + arc unit

Event Timeline

sbz retitled this revision from to New port: devel/go-errors.
sbz updated this object.
sbz edited the test plan for this revision. (Show Details)
sbz added reviewers: mat, jlaffaye.

add it for the category Makefile

Do not modify svn property

devel/go-errors/Makefile
5

This should be PORTNAME=errors / PKGNAMEPREFIX=go- so that you can remove th GH_PROJECT line afterwards.

Please do not create ports/packages for Go libraries. It's better to add the lib as another distfile in ports that need it.

sbz marked an inline comment as done.Dec 18 2016, 5:52 PM

@mat Fixed! Thank you

@swills I need it as build dependency for a port I will bring into the port tree. As It's a library, it's useful to have a separate ports/package for it like that it could be reused in case another port need it.

Also, there are already lot of go libraries in the ports tree (cf. pkg search -g 'go-*'), why you want to prevent me for adding this one ?

mat added a subscriber: bapt.
In D8837#183007, @sbz wrote:

@swills I need it as build dependency for a port I will bring into the port tree. As It's a library, it's useful to have a separate ports/package for it like that it could be reused in case another port need it.

Also, there are already lot of go libraries in the ports tree (cf. pkg search -g 'go-*'), why you want to prevent me for adding this one ?

Because, like @bapt told you, it is not how the ports tree works wrt Go.

What ports do is add distfile for the libraries they need, put them in the right place, and let go build everything at once.

@mat It's another approach which do not use multiple distfiles and do not build required dependencies into ${WRKSRC} at once.

I think sharing the archive .a is a sane way to do it.

My approach works without multiples distfiles and use BUILD_DEPENDS to satisfy the go build dependencies.

Also, there are already other go packages included in the port tree...

sbz edited edge metadata.