Page MenuHomeFreeBSD
Differential D8751

Fix gic_cpu_mask calculation
ClosedPublic
Actions

Authored by jchandra on Dec 11 2016, 7:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 15, 10:59 PM
Unknown Object (File)
Wed, Nov 12, 1:10 AM
Unknown Object (File)
Sat, Nov 8, 8:14 PM
Unknown Object (File)
Sat, Nov 8, 8:14 PM
Unknown Object (File)
Sat, Nov 8, 4:14 PM
Unknown Object (File)
Oct 26 2025, 8:18 AM
Unknown Object (File)
Sep 17 2025, 9:48 AM
Unknown Object (File)
Aug 13 2025, 11:02 PM
View All 52 Files
Subscribers
imp

Details

Reviewers
jchandra
andrew
freebsd-arm-list
Group Reviewers
arm64
Summary

r309616 changed the definition of GICD_ITARGETSR(n) right shift n
by 2, but the usage of the macro in gic_cpu_mask() was not updated
to reflect this. This causes the cpu mask to be computed incorrectly.




Fix this by updating gic_cpu_mask(). This fixes a hang seen when

booting on ARM64 with SMP enabled.
Diff Detail
Repository 
rS FreeBSD src repository - subversion 
Lint 
Lint Skipped
 
Unit 
Tests Skipped
 
Build Status 
Buildable 6187
 
Event Timeline
jchandra updated this revision to Diff 22814.Dec 11 2016, 7:53 PM
jchandra retitled this revision from  to Fix gic_cpu_mask calculation.
jchandra updated this object.
jchandra edited the test plan for this revision. (Show Details)
jchandra added reviewers: arm64, freebsd-arm-list, andrew.
jchandra set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp.  ·  View Herald TranscriptDec 11 2016, 7:53 PM
jchandra accepted this revision.Dec 16 2016, 6:49 PM
jchandra added a reviewer: jchandra.
checked in r309892
This revision is now accepted and ready to land.Dec 16 2016, 6:49 PM
jchandra closed this revision.Dec 16 2016, 6:50 PM
Revision Contents
Changeset List
PathSize
sys/
arm/
arm/
2 lines
Diff 22814
View Options
sys/arm/arm/gic.c
Loading...