Fix gic_cpu_mask calculation
ClosedPublic
Actions

Authored by jchandra on Dec 11 2016, 7:53 PM.

Tags

None

Referenced Files

	F170102668: D8751.id.diff
	Thu, Sep 3, 12:42 PM

	Unknown Object (File)
	Wed, Sep 2, 4:52 PM

	Unknown Object (File)
	Wed, Sep 2, 11:32 AM

	Unknown Object (File)
	Tue, Sep 1, 11:58 AM

	Unknown Object (File)
	Mon, Aug 31, 3:58 PM

	Unknown Object (File)
	Mon, Aug 31, 11:52 AM

	Unknown Object (File)
	Sun, Aug 30, 9:04 AM

	Unknown Object (File)
	Sat, Aug 29, 12:04 PM

View All 79 Files

Subscribers

imp

Details

Reviewers

jchandra
andrew
freebsd-arm-list

Group Reviewers

arm64

Summary

r309616 changed the definition of GICD_ITARGETSR(n) right shift n
by 2, but the usage of the macro in gic_cpu_mask() was not updated
to reflect this. This causes the cpu mask to be computed incorrectly.

Fix this by updating gic_cpu_mask(). This fixes a hang seen when
booting on ARM64 with SMP enabled.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 6187

Event Timeline

jchandra updated this revision to Diff 22814.Dec 11 2016, 7:53 PM

jchandra retitled this revision from to Fix gic_cpu_mask calculation.

jchandra updated this object.

jchandra edited the test plan for this revision. (Show Details)

jchandra added reviewers: arm64, freebsd-arm-list, andrew.

jchandra set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2016, 7:53 PM

checked in r309892

This revision is now accepted and ready to land.Dec 16 2016, 6:49 PM

jchandra closed this revision.Dec 16 2016, 6:50 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

gic.c

2 lines

Diff 22814

View Options

Fix gic_cpu_mask calculationClosedPublicActions