Page MenuHomeFreeBSD
Differential D8649

science/afni: Use BUILD_DEPENDS/RUN_DEPENDS instead of LIB_DEPENDS for math/R, because R may be configured without libR.so.
ClosedPublic
Actions

Authored by jrm on Nov 27 2016, 2:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 5:50 PM
Unknown Object (File)
Fri, Apr 12, 10:48 PM
Unknown Object (File)
Sun, Mar 31, 9:37 PM
Unknown Object (File)
Thu, Mar 28, 4:30 PM
Unknown Object (File)
Thu, Mar 28, 9:53 AM
Unknown Object (File)
Dec 30 2023, 9:30 AM
Unknown Object (File)
Dec 30 2023, 9:29 AM
Unknown Object (File)
Dec 19 2023, 7:04 PM
View All 34 Files
Subscribers
mat

Details

Reviewers
swills
AMDmi3
bacon4000_gmail.com
Commits
rP427397: science/afni: Use BUILD_DEPENDS/RUN_DEPENDS instead of LIB_DEPENDS for
Summary

science/afni: Use BUILD_DEPENDS/RUN_DEPENDS instead of LIB_DEPENDS for

math/R, because R may be configured without libR.so

Also, after some planned changes ${PREFIX}/lib/R/lib will not be registered
with ldconfig. While here, fix some stage-qa warnings about indirect
dependencies.

Test Plan

portlint -AC: OK
testport: OK (poudriere: 10.3-RELEASE-p10, i386)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64)
testport: OK (poudriere: 11.0-RELEASE-p1, i386)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm updated this revision to Diff 22534.Nov 27 2016, 2:30 AM
jrm retitled this revision from to science/afni: Use BUILD_DEPENDS/RUN_DEPENDS instead of LIB_DEPENDS for math/R, because R may be configured without libR.so..
jrm updated this object.
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: swills, AMDmi3, bacon4000_gmail.com.
Herald added a subscriber: mat. · View Herald TranscriptNov 27 2016, 2:30 AM
jrm added a child revision: D8650: Fix build issue when the LTO option is enabled [1], do not register ${PREFIX}/lib/R/lib with ldconfig [2], and fix typo..Nov 27 2016, 3:52 AM
bacon4000_gmail.com edited edge metadata.Nov 27 2016, 7:15 PM

Patch tested and approved.

AMDmi3 added inline comments.Nov 28 2016, 2:11 PM
science/afni/Makefile
25 ↗(On Diff #22534)

USE_XORG=xp

jrm updated this revision to Diff 22576.Nov 28 2016, 3:21 PM
jrm edited edge metadata.

USE_XORG=xp instead of LIB_DEPENDS=libXp.so:x11/libXp

  1. Updating D8649: science/afni: Use BUILD_DEPENDS/RUN_DEPENDS instead of LIB_DEPENDS for math/R, because R may be configured without libR.so.
bacon4000_gmail.com added a comment.Nov 28 2016, 3:32 PM

Good idea. I added USE_XORG= to my submit checklist.

Maybe portlint or stage QA could be enhanced to flag opportunities like this?

swills accepted this revision.Nov 29 2016, 9:11 PM
swills edited edge metadata.

Approved

This revision is now accepted and ready to land.Nov 29 2016, 9:11 PM
Closed by commit rP427397: science/afni: Use BUILD_DEPENDS/RUN_DEPENDS instead of LIB_DEPENDS for (authored by jrm). · Explain WhyNov 29 2016, 9:16 PM
This revision was automatically updated to reflect the committed changes.
jrm marked an inline comment as done.

Revision Contents
Changeset List

PathSize
head/
science/
afni/
21 lines

Diff 22600

View Options

head/science/afni/Makefile

Loading...