Page MenuHomeFreeBSD
Differential D8614

ofw_spibus Parse spi-cpol, spi-cpha and spi-cs-high
ClosedPublic
Actions

Authored by manu on Nov 22 2016, 5:34 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, May 3, 12:18 AM
Unknown Object (File)
Sun, Apr 28, 3:14 PM
Unknown Object (File)
Sun, Apr 28, 3:13 PM
Unknown Object (File)
Sat, Apr 27, 1:16 PM
Unknown Object (File)
Sat, Apr 27, 1:16 PM
Unknown Object (File)
Sat, Apr 27, 1:15 PM
Unknown Object (File)
Sat, Apr 27, 1:15 PM
Unknown Object (File)
Mar 16 2024, 3:45 AM
View All 68 Files
Subscribers
imp
loos
ARM

Details

Reviewers
loos
Group Reviewers
ARM
Commits
rS310229: ofw_spi: Parse property for the SPI mode and CS polarity.
Summary

Parse OFW property for the SPI mode and CS polarity.
As cs is stored in a uint32_t, use the last bit to store the active high flag as it's unlikely that we will have that much CS.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6038
Build 6304: arc lint + arc unit

Event Timeline

manu updated this revision to Diff 22437.Nov 22 2016, 5:34 PM
manu retitled this revision from to ofw_spibus Parse spi-cpol, spi-cpha and spi-cs-high.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
manu added a subscriber: ARM.
Herald added a subscriber: imp. · View Herald TranscriptNov 22 2016, 5:34 PM
manu updated this revision to Diff 22438.Nov 22 2016, 5:54 PM
manu removed rS FreeBSD src repository - subversion as the repository for this revision.

Use correct define ...

loos added a subscriber: loos.Nov 27 2016, 8:46 PM

It looks good to me, but I guess we need to sweep existing code to mask the result of get_spibus_cs() now ?

manu added a comment.Dec 12 2016, 5:54 PM
In D8614#179408, @loos wrote:

It looks good to me, but I guess we need to sweep existing code to mask the result of get_spibus_cs() now ?

True, I'll make a pass and add this to this review.

manu updated this revision to Diff 22853.Dec 12 2016, 8:40 PM

Mask out CS_HIGH bit from cs.

loos added inline comments.Dec 17 2016, 2:48 AM
sys/arm/at91/at91_spi.c
304 ↗(On Diff #22853)

Is the parentheses necessary here ?

sys/dev/spibus/spibusvar.h
49

I think you have to use (1U << 31) here to stay on safe side.

manu updated this revision to Diff 23023.Dec 17 2016, 12:11 PM

Remove uneeded parenthesis and specify 1U

manu marked 2 inline comments as done.Dec 17 2016, 12:11 PM
loos accepted this revision.Dec 17 2016, 5:45 PM
loos added a reviewer: loos.

Thank you!

This revision is now accepted and ready to land.Dec 17 2016, 5:45 PM
Closed by commit rS310229: ofw_spi: Parse property for the SPI mode and CS polarity. (authored by manu). · Explain WhyDec 18 2016, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
spibus/
20 lines
2 lines

Diff 22437

View Options

sys/dev/spibus/ofw_spibus.c

Loading...
View Options

sys/dev/spibus/spibusvar.h

Loading...