Page MenuHomeFreeBSD
Differential D8604

disambiguate msleep KASSERT diagnostics
ClosedPublic
Actions

Authored by emaste on Nov 21 2016, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 6:24 PM
Unknown Object (File)
Sep 18 2024, 4:06 PM
Unknown Object (File)
Sep 3 2024, 2:53 AM
Unknown Object (File)
Sep 2 2024, 9:08 PM
Unknown Object (File)
Aug 29 2024, 3:35 AM
Unknown Object (File)
Aug 28 2024, 2:29 PM
Unknown Object (File)
Aug 22 2024, 1:55 AM
Unknown Object (File)
Aug 20 2024, 11:38 PM
View All 67 Files
Subscribers
kib

Details

Reviewers
kib
jhb
Commits
rS312311: disambiguate msleep KASSERT diagnostics
Summary

I encountered "panic: msleep" while investigating an issue, which led to @kib's change in D8421. I applied the change here locally while investigating, because four different cases would result in the same panic string. There may be a better way to disambiguate these cases though; what do you think?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 22407.Nov 21 2016, 3:32 PM
emaste retitled this revision from to disambiguate msleep KASSERT diagnostics.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: kib, jhb.
emaste added a subscriber: kib.
kib accepted this revision.Nov 21 2016, 3:42 PM
kib edited edge metadata.
kib added inline comments.
sys/kern/kern_synch.c
155 ↗(On Diff #22407)

What about this line ? Although I think that we cannot really get this asserted even for extremely broken kernels.

157 ↗(On Diff #22407)

Might be say 'current thread is not running' instead of td.

This revision is now accepted and ready to land.Nov 21 2016, 3:42 PM
jhb accepted this revision.Nov 22 2016, 6:18 PM
jhb edited edge metadata.
jhb added inline comments.
sys/kern/kern_synch.c
155 ↗(On Diff #22407)

Yeah, that is old (in 4.x p was NULL in the idle loop, but that was also all in assembly). It can probably go away. As bde@ would point out it will panic shortly anyway via a trap when td is dereferenced.

157 ↗(On Diff #22407)

Or "curthread not running". I think the existing message is ok as well.

Closed by commit rS312311: disambiguate msleep KASSERT diagnostics (authored by emaste). · Explain WhyJan 16 2017, 8:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
8 lines

Diff 24078

View Options

head/sys/kern/kern_synch.c

Loading...