Page MenuHomeFreeBSD
Differential D8591

Adjustments to systat(1)
ClosedPublic
Actions

Authored by sevan on Nov 20 2016, 6:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 8 2024, 11:34 AM
Unknown Object (File)
Oct 20 2024, 4:51 PM
Unknown Object (File)
Oct 19 2024, 7:54 PM
Unknown Object (File)
Oct 18 2024, 4:25 AM
Unknown Object (File)
Oct 18 2024, 4:25 AM
Unknown Object (File)
Oct 18 2024, 4:25 AM
Unknown Object (File)
Oct 18 2024, 4:25 AM
Unknown Object (File)
Oct 18 2024, 4:24 AM
View All 88 Files
Subscribers
imp
jilles

Details

Reviewers
jilles
bcr
Group Reviewers
manpages
Commits
rS316194: MFC r309552
rS316191: MFC 309552
rS309552: Fix error in the example section
Summary

Fix the mistake in the example (bug 214683).
Adjust formatting highlighted by igor.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sevan updated this revision to Diff 22368.Nov 20 2016, 6:24 PM
sevan retitled this revision from to Adjustments to systat(1).
sevan updated this object.
sevan edited the test plan for this revision. (Show Details)
sevan added a reviewer: bcr.
sevan set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: manpages. · View Herald TranscriptNov 20 2016, 6:24 PM
Herald added a subscriber: imp. · View Herald Transcript
bcr accepted this revision.Nov 20 2016, 6:36 PM
bcr edited edge metadata.

Looks good to me. Make sure to reference the PR in the commit and set an MFC period.

This revision is now accepted and ready to land.Nov 20 2016, 6:36 PM
jilles added a subscriber: jilles.Nov 20 2016, 6:44 PM
jilles added inline comments.
usr.bin/systat/systat.1
115 ↗(On Diff #22368)

A line break for a new sentence is needed here as well.

"specific to" sounds better than "specific for" to me here.

118–121 ↗(On Diff #22368)

Somehow the phrasing sounds awkward (unrelated to your change).

Perhaps something like:

If the command requires arguments,
they can be specified as separate command line arguments.
A command line argument
.Fl -
will finish display commands.
bcr requested changes to this revision.Nov 20 2016, 6:52 PM
bcr edited edge metadata.

Right, we should fix that first.

This revision now requires changes to proceed.Nov 20 2016, 6:52 PM
sevan updated this revision to Diff 22370.Nov 20 2016, 7:08 PM
sevan edited edge metadata.
sevan removed rS FreeBSD src repository - subversion as the repository for this revision.
sevan marked 2 inline comments as done.
bcr added inline comments.Nov 20 2016, 7:23 PM
usr.bin/systat/systat.1
118 ↗(On Diff #22370)

the "of" is still there.

sevan updated this revision to Diff 22373.Nov 20 2016, 8:33 PM
sevan edited edge metadata.
sevan set the repository for this revision to rS FreeBSD src repository - subversion.
sevan marked an inline comment as done.Nov 20 2016, 8:35 PM

Updated diff dropping the extraneous word of posted.

bcr accepted this revision.Nov 20 2016, 8:37 PM
bcr edited edge metadata.
This revision is now accepted and ready to land.Nov 20 2016, 8:37 PM
jilles accepted this revision.Nov 20 2016, 8:56 PM
jilles added a reviewer: jilles.
sevan added a comment.Dec 5 2016, 11:08 AM

ok to commit?

bcr added a comment.Dec 5 2016, 1:02 PM

yes, go ahead. Make sure to change the date in the man page to today, because that is when the change happened.

Closed by commit rS309552: Fix error in the example section (authored by sevan). · Explain WhyDec 5 2016, 1:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
systat/
19 lines

Diff 22715

View Options

head/usr.bin/systat/systat.1

Loading...