Page MenuHomeFreeBSD

Adjustments to systat(1)
ClosedPublic

Authored by sevan on Nov 20 2016, 6:24 PM.

Details

Summary

Fix the mistake in the example (bug 214683).
Adjust formatting highlighted by igor.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sevan retitled this revision from to Adjustments to systat(1).
sevan updated this object.
sevan edited the test plan for this revision. (Show Details)
sevan added a reviewer: bcr.
sevan set the repository for this revision to rS FreeBSD src repository - subversion.
bcr edited edge metadata.

Looks good to me. Make sure to reference the PR in the commit and set an MFC period.

This revision is now accepted and ready to land.Nov 20 2016, 6:36 PM
jilles added inline comments.
usr.bin/systat/systat.1
115 ↗(On Diff #22368)

A line break for a new sentence is needed here as well.

"specific to" sounds better than "specific for" to me here.

118–121 ↗(On Diff #22368)

Somehow the phrasing sounds awkward (unrelated to your change).

Perhaps something like:

If the command requires arguments,
they can be specified as separate command line arguments.
A command line argument
.Fl -
will finish display commands.
bcr requested changes to this revision.Nov 20 2016, 6:52 PM
bcr edited edge metadata.

Right, we should fix that first.

This revision now requires changes to proceed.Nov 20 2016, 6:52 PM
sevan edited edge metadata.
sevan removed rS FreeBSD src repository - subversion as the repository for this revision.
sevan marked 2 inline comments as done.
usr.bin/systat/systat.1
118 ↗(On Diff #22370)

the "of" is still there.

sevan edited edge metadata.
sevan set the repository for this revision to rS FreeBSD src repository - subversion.

Updated diff dropping the extraneous word of posted.

bcr edited edge metadata.
This revision is now accepted and ready to land.Nov 20 2016, 8:37 PM
jilles added a reviewer: jilles.

yes, go ahead. Make sure to change the date in the man page to today, because that is when the change happened.

This revision was automatically updated to reflect the committed changes.