Add a GPIO poweroff and reset driver.
ClosedPublic
Actions

Authored by jhibbits on Nov 15 2016, 5:02 AM.

Details

Reviewers

gonzo
imp
adrian

Commits

rS308709: Add a GPIO poweroff and reset driver.

Summary

This implements part of the gpio-poweroff and gpio-restart device tree
bindings. Optional properties are not handled currently. It also currently
only supports level-triggered reset.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits updated this revision to Diff 22208.Nov 15 2016, 5:02 AM

jhibbits retitled this revision from to Add a GPIO poweroff and reset driver..

jhibbits updated this object.

jhibbits edited the test plan for this revision. (Show Details)

jhibbits added reviewers: gonzo, adrian, imp.

Herald added a subscriber: loos. · View Herald TranscriptNov 15 2016, 5:02 AM

Except for two nitpicks driver looks OK

sys/dev/gpio/gpiopower.c
84 ↗	(On Diff #22208)	May be a good idea to print it only for verbose boot. This information is of no use to normal user.
111 ↗	(On Diff #22208)	I think the convention here is not to capitalize message, so it, "dev0: message" looks more natural than "dev0: Message"