Page MenuHomeFreeBSD
Differential D8425

Allwinner H3 audio codec support
ClosedPublic
Actions

Authored by jmcneill on Nov 3 2016, 12:13 AM.
Tags
Referenced Files
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Sep 30 2024, 6:10 PM
Unknown Object (File)
Sep 29 2024, 10:24 PM
Unknown Object (File)
Sep 28 2024, 7:35 PM
Unknown Object (File)
Sep 28 2024, 9:45 AM
Unknown Object (File)
Sep 28 2024, 3:31 AM
Unknown Object (File)
Sep 5 2024, 11:50 PM
Unknown Object (File)
Aug 29 2024, 5:17 PM
View All 85 Files
Subscribers
andrew
ganbold
imp

Details

Reviewers
manu
ganbold
Group Reviewers
ARM
Commits
rS308269: Add support for Allwinner H3 audio codec.
Summary

This patch adds support for the H3 audio codec. Audio controller is mostly the same as A10/A20 except some registers are shuffled around. The mixer interfaces are completely different between SoCs, so separate a10_mixer_class and h3_mixer_class are implemented.

Test Plan

Needs to be tested on an A10 or A20 board.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jmcneill updated this revision to Diff 21957.Nov 3 2016, 12:13 AM
jmcneill retitled this revision from to Allwinner H3 audio codec support.
jmcneill updated this object.
jmcneill edited the test plan for this revision. (Show Details)
jmcneill added reviewers: ARM, manu.
jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.
jmcneill added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptNov 3 2016, 12:13 AM
ganbold accepted this revision.Nov 3 2016, 2:18 AM
ganbold added a reviewer: ganbold.
ganbold added a subscriber: ganbold.

Audio works nicely on A20 device (Cubieboard2)

This revision is now accepted and ready to land.Nov 3 2016, 2:18 AM
andrew added inline comments.Nov 3 2016, 10:33 AM
sys/arm/allwinner/a10_codec.c
68 ↗(On Diff #21957)

Would it pay to add a mute method to the mixer interface?

jmcneill added inline comments.Nov 3 2016, 12:48 PM
sys/arm/allwinner/a10_codec.c
68 ↗(On Diff #21957)

I think I can get away with muting/unmuting in mixer_set but for now I wanted to follow the model used by the existing driver. Getting rid of this callback would be a good future enhancement though.

Closed by commit rS308269: Add support for Allwinner H3 audio codec. (authored by jmcneill). · Explain WhyNov 3 2016, 11:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
allwinner/
681 lines

Diff 21984

View Options

head/sys/arm/allwinner/a10_codec.c

Loading...