Page MenuHomeFreeBSD

Allwinner H3 audio codec support
ClosedPublic

Authored by jmcneill on Nov 3 2016, 12:13 AM.

Details

Summary

This patch adds support for the H3 audio codec. Audio controller is mostly the same as A10/A20 except some registers are shuffled around. The mixer interfaces are completely different between SoCs, so separate a10_mixer_class and h3_mixer_class are implemented.

Test Plan

Needs to be tested on an A10 or A20 board.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmcneill updated this revision to Diff 21957.Nov 3 2016, 12:13 AM
jmcneill retitled this revision from to Allwinner H3 audio codec support.
jmcneill updated this object.
jmcneill edited the test plan for this revision. (Show Details)
jmcneill added reviewers: ARM, manu.
jmcneill set the repository for this revision to rS FreeBSD src repository.
jmcneill added a project: ARM.
ganbold accepted this revision.Nov 3 2016, 2:18 AM
ganbold added a reviewer: ganbold.
ganbold added a subscriber: ganbold.

Audio works nicely on A20 device (Cubieboard2)

This revision is now accepted and ready to land.Nov 3 2016, 2:18 AM
andrew added inline comments.Nov 3 2016, 10:33 AM
sys/arm/allwinner/a10_codec.c
68 ↗(On Diff #21957)

Would it pay to add a mute method to the mixer interface?

jmcneill added inline comments.Nov 3 2016, 12:48 PM
sys/arm/allwinner/a10_codec.c
68 ↗(On Diff #21957)

I think I can get away with muting/unmuting in mixer_set but for now I wanted to follow the model used by the existing driver. Getting rid of this callback would be a good future enhancement though.

This revision was automatically updated to reflect the committed changes.