Page MenuHomeFreeBSD

Fix ip_output() on point-to-point links
ClosedPublic

Authored by rstone on Oct 20 2016, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 14, 9:03 PM
Unknown Object (File)
Jun 23 2025, 9:21 PM
Unknown Object (File)
Jun 23 2025, 7:59 AM
Unknown Object (File)
Jun 21 2025, 3:41 PM
Unknown Object (File)
Jun 19 2025, 1:51 PM
Unknown Object (File)
Jun 11 2025, 4:54 PM
Unknown Object (File)
Jun 7 2025, 6:19 AM
Unknown Object (File)
Jun 4 2025, 5:01 AM
Subscribers

Details

Summary

In r304435, ip_output() was changed to use the result of the route
lookup to decide whether the outgoing packet was a broadcast or
not. This introduced a regression on interfaces where
IFF_BROADCAST was not set (e.g. point-to-point links), as the
algorithm could incorrectly treat the destination address as a
broadcast address, and ip_output() would subsequently drop the
packet as broadcasting on a non-IFF_BROADCAST interface is not
allowed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rstone retitled this revision from to Fix ip_output() on point-to-point links.
rstone edited the test plan for this revision. (Show Details)
rstone added a reviewer: transport.
rstone updated this object.
jtl added a reviewer: jtl.
This revision is now accepted and ready to land.Oct 20 2016, 6:53 PM
This revision was automatically updated to reflect the committed changes.