Page MenuHomeFreeBSD

Fix ip_output() on point-to-point links
ClosedPublic

Authored by rstone on Oct 20 2016, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 13 2025, 7:39 PM
Unknown Object (File)
Jan 13 2025, 6:05 PM
Unknown Object (File)
Jan 8 2025, 2:53 PM
Unknown Object (File)
Dec 27 2024, 12:44 AM
Unknown Object (File)
Dec 23 2024, 3:41 AM
Unknown Object (File)
Nov 20 2024, 8:11 PM
Unknown Object (File)
Nov 11 2024, 7:24 PM
Unknown Object (File)
Oct 30 2024, 9:33 AM
Subscribers

Details

Summary

In r304435, ip_output() was changed to use the result of the route
lookup to decide whether the outgoing packet was a broadcast or
not. This introduced a regression on interfaces where
IFF_BROADCAST was not set (e.g. point-to-point links), as the
algorithm could incorrectly treat the destination address as a
broadcast address, and ip_output() would subsequently drop the
packet as broadcasting on a non-IFF_BROADCAST interface is not
allowed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rstone retitled this revision from to Fix ip_output() on point-to-point links.
rstone edited the test plan for this revision. (Show Details)
rstone added a reviewer: transport.
rstone updated this object.
jtl added a reviewer: jtl.
This revision is now accepted and ready to land.Oct 20 2016, 6:53 PM
This revision was automatically updated to reflect the committed changes.