Page MenuHomeFreeBSD

Fix ip_output() on point-to-point links
ClosedPublic

Authored by rstone on Oct 20 2016, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 10, 6:07 AM
Unknown Object (File)
Fri, May 8, 10:30 PM
Unknown Object (File)
Wed, Apr 29, 3:37 PM
Unknown Object (File)
Wed, Apr 29, 2:56 PM
Unknown Object (File)
Wed, Apr 29, 3:33 AM
Unknown Object (File)
Tue, Apr 28, 11:07 PM
Unknown Object (File)
Thu, Apr 16, 7:34 AM
Unknown Object (File)
Apr 14 2026, 3:36 AM
Subscribers

Details

Summary

In r304435, ip_output() was changed to use the result of the route
lookup to decide whether the outgoing packet was a broadcast or
not. This introduced a regression on interfaces where
IFF_BROADCAST was not set (e.g. point-to-point links), as the
algorithm could incorrectly treat the destination address as a
broadcast address, and ip_output() would subsequently drop the
packet as broadcasting on a non-IFF_BROADCAST interface is not
allowed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rstone retitled this revision from to Fix ip_output() on point-to-point links.
rstone edited the test plan for this revision. (Show Details)
rstone added a reviewer: transport.
rstone updated this object.
jtl added a reviewer: jtl.
This revision is now accepted and ready to land.Oct 20 2016, 6:53 PM
This revision was automatically updated to reflect the committed changes.