Implement the fpu_kern(9) KPI on arm64
ClosedPublic
Actions

Authored by andrew on Oct 18 2016, 1:56 PM.

Details

Reviewers

kib

Group Reviewers

arm64

Commits

rS307667: Add support for the fpu_kern(9) KPI on arm64. It hooks into the existing

Summary

Add support for the fpu_kern(9) KPI for arm64. It hooks into the existing
VFP code to store the old context, with lazy loading of the new context
when needed.

FPU_KERN_NOCTX is missing as this is unused in the crypto code this has
been tested with, and I am unsure on the requirements of the UEFI
Runtime Services.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew updated this revision to Diff 21472.Oct 18 2016, 1:56 PM

andrew retitled this revision from to Implement the fpu_kern(9) KPI on arm64.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added reviewers: arm64, kib.

andrew added a subscriber: emaste.

kib accepted this revision.Oct 18 2016, 2:51 PM

kib edited edge metadata.

kib added inline comments.

sys/arm64/arm64/trap.c
285 ↗	(On Diff #21472)	You might add an assert in do_el0_sync() that pcb_fpflags has PCB_FP_KERN cleared and that pcb->pcb_fpusaved == &pcb->pcb_fpustate. There, you probably want to assert !=.
sys/arm64/arm64/vfp.c
246 ↗	(On Diff #21472)	You initialize the new kernel vfp save area with zeroes. This includes the vfp_fpcr and vfp_fpsr values loaded on vfp access. Are 0's the correct values there ?
sys/opencrypto/crypto.c
1249 ↗	(On Diff #21472)	This change is not needed yet ? There is no arm64 files added to aesni module.

This revision is now accepted and ready to land.Oct 18 2016, 2:51 PM

The fpu_kern(9) man page should be updated, with a note that arm64 is included in the supported arches.

andrew added inline comments.Oct 18 2016, 3:36 PM

sys/arm64/arm64/trap.c
285 ↗	(On Diff #21472)	I thought I did, but seem to have lost that change.
sys/arm64/arm64/vfp.c
246 ↗	(On Diff #21472)	The kernel only ever initialises fpsr and fpcr to 0.
sys/opencrypto/crypto.c
1249 ↗	(On Diff #21472)	There will be soon, I have the code ready, just need the last bits of clean up. I included this with this change so some of the code would be tested.