Differential D8259

Make the USB attach strings in dmesg include product name.
ClosedPublic
Actions

Authored by trasz on Oct 15 2016, 11:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 8:04 AM

	Unknown Object (File)
	Sun, Dec 1, 8:02 PM

	Unknown Object (File)
	Oct 19 2024, 7:27 PM

	Unknown Object (File)
	Oct 3 2024, 9:37 PM

	Unknown Object (File)
	Oct 2 2024, 7:05 AM

	Unknown Object (File)
	Oct 1 2024, 12:29 PM

	Unknown Object (File)
	Sep 27 2024, 12:53 PM

	Unknown Object (File)
	Sep 15 2024, 3:10 AM

View All 67 Files

Subscribers

Details

Reviewers

Commits

rS307902: Make the USB attach strings in dmesg include product name.

Summary

Make the USB attach strings in dmesg include product name.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5688
Build 5980: CI src build	Jenkins
Build 5979: arc lint + arc unit

Event Timeline

trasz updated this revision to Diff 21423.Oct 15 2016, 11:24 PM

trasz retitled this revision from to Make the USB attach strings in dmesg include product name..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptOct 15 2016, 11:24 PM

trasz added a reviewer: • hselasky.Oct 15 2016, 11:25 PM

Looks good to my eye (I thought I'd done something similar to the USB stack before Hans took it over).

• hselasky added inline comments.Oct 21 2016, 9:32 AM

sys/dev/usb/usb_util.c
98 ↗	(On Diff #21423)	Are you checking iManufacturer for 0 ?

Don't mess with device_set_usb_desc() for now.

trasz added inline comments.Oct 22 2016, 5:24 PM

sys/dev/usb/usb_util.c
98 ↗	(On Diff #21423)	Well, usbd_req_get_string_any() already handles this, but I'll try to do this in a cleaner way. For now let's forget about this chunk.

Looks good. Approved.

This revision is now accepted and ready to land.Oct 22 2016, 8:15 PM

Don't forget to MFC all the way back to 8-stable.

Closed by commit rS307902: Make the USB attach strings in dmesg include product name. (authored by trasz). · Explain WhyOct 25 2016, 7:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

8 lines

Diff 21620

sys/dev/usb/usb_device.c

Loading...