partially convert lib/Makefile to SUBDIR.${MK_FOO} style
ClosedPublic
Actions

Authored by emaste on Oct 13 2016, 9:41 PM.

Details

Reviewers

imp
bdrewery

Commits

Summary

Cases other than MK_FOO, e.g. ${MACHINE_CPUARCH} == "i386", have been left as is.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

emaste retitled this revision from to partially convert lib/Makefile to SUBDIR.${MK_FOO} style.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: imp, bdrewery.

emaste added a subscriber: ed.

Rush this in before it can go stale.

lib/Makefile
173–174 ↗	(On Diff #21376)	Question: can MK_BHYVE be yes when MACHINE_CPUARCH != amd64?

This revision is now accepted and ready to land.Oct 13 2016, 9:44 PM

lib/Makefile
173–174 ↗	(On Diff #21376)	Interesting, it seems `BHYVE` is in `__DEFAULT_YES_OPTIONS`. It's wrapped in `${MACHINE_CPUARCH} == "amd64"` here, and `bhyve`/`bhyvectl`/`bhyveload`are only included in usr.sbin/Makefile.amd64. This seems wrong to me, and should be cleaned up in a subsequent patch.