Page MenuHomeFreeBSD
Differential D8239

fix strchr, strrchr implementation on MIPS
ClosedPublic
Actions

Authored by br on Oct 13 2016, 11:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 6:27 AM
Unknown Object (File)
Fri, Nov 21, 8:16 AM
Unknown Object (File)
Nov 13 2025, 12:03 PM
Unknown Object (File)
Nov 4 2025, 2:44 AM
Unknown Object (File)
Nov 3 2025, 12:37 PM
Unknown Object (File)
Nov 3 2025, 12:36 PM
Unknown Object (File)
Nov 3 2025, 12:36 PM
Unknown Object (File)
Nov 3 2025, 12:35 PM
View All Files
Subscribers
None

Details

Reviewers
emaste
andrew
Commits
rS307219: Fix strchr, strrchr implementation: convert c to char
Summary

compare byte with byte, not byte with int

this is a fix for the following tests:

bin/sh/expansion/functional_test:ifs3
bin/sh/expansion/functional_test:plus_minus6
lib/libc/string/strchr_test:strchr_basic
lib/libc/string/strrchr_test:strrchr_basic

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br updated this revision to Diff 21350.Oct 13 2016, 11:40 AM
br retitled this revision from to fix strchr, strrchr implementation on MIPS.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added reviewers: emaste, andrew.
andrew edited edge metadata.Oct 13 2016, 11:54 AM

This looks correct, http://pubs.opengroup.org/onlinepubs/9699919799/functions/strchr.html states c should be converted to a char.

emaste accepted this revision.Oct 13 2016, 12:06 PM
emaste edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 13 2016, 12:06 PM
Closed by commit rS307219: Fix strchr, strrchr implementation: convert c to char (authored by br). · Explain WhyOct 13 2016, 3:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libc/
mips/
string/
5 lines
5 lines

Diff 21350

View Options

lib/libc/mips/string/strchr.S

Loading...
View Options

lib/libc/mips/string/strrchr.S

Loading...