Paths

Table of Contentst

fix strchr, strrchr implementation on MIPS
ClosedPublic
Actions

Authored by br on Oct 13 2016, 11:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 31, 5:31 AM

	Unknown Object (File)
	Sat, Jul 26, 5:34 PM

	Unknown Object (File)
	Sat, Jul 26, 1:24 PM

	Unknown Object (File)
	Thu, Jul 24, 10:24 AM

	Unknown Object (File)
	Jun 28 2025, 4:50 PM

	Unknown Object (File)
	Jun 24 2025, 9:43 PM

	Unknown Object (File)
	Jun 24 2025, 6:30 PM

	Unknown Object (File)
	Jun 23 2025, 7:39 AM

View All Files

Subscribers

None

Details

Reviewers

emaste
andrew

Commits

rS307219: Fix strchr, strrchr implementation: convert c to char

Summary

compare byte with byte, not byte with int

this is a fix for the following tests:

bin/sh/expansion/functional_test:ifs3
bin/sh/expansion/functional_test:plus_minus6
lib/libc/string/strchr_test:strchr_basic
lib/libc/string/strrchr_test:strrchr_basic

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br updated this revision to Diff 21350.Oct 13 2016, 11:40 AM

br retitled this revision from to fix strchr, strrchr implementation on MIPS.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added reviewers: emaste, andrew.

This looks correct, http://pubs.opengroup.org/onlinepubs/9699919799/functions/strchr.html states c should be converted to a char.

LGTM

This revision is now accepted and ready to land.Oct 13 2016, 12:06 PM

Closed by commit rS307219: Fix strchr, strrchr implementation: convert c to char (authored by br). · Explain WhyOct 13 2016, 3:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

mips/

string/

strchr.S

5 lines

strrchr.S

5 lines

Diff 21353

View Options

head/lib/libc/mips/string/strchr.S