Page MenuHomeFreeBSD

Include ALL_MODULES in MKMODULESENV
AcceptedPublic

Authored by jtl on Oct 12 2016, 8:20 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Oct 11, 7:14 AM
Unknown Object (File)
Sat, Sep 27, 11:36 PM
Unknown Object (File)
Sep 6 2025, 12:01 PM
Unknown Object (File)
Aug 26 2025, 6:20 AM
Unknown Object (File)
Aug 26 2025, 5:49 AM
Unknown Object (File)
Aug 26 2025, 5:49 AM
Unknown Object (File)
Aug 26 2025, 5:36 AM
Unknown Object (File)
Aug 26 2025, 5:34 AM
Subscribers

Details

Reviewers
sjg
imp
bdrewery
Summary

While testing another change, I noticed that we don't include ALL_MODULES
in MKMODULESENV. It seems like we should do that when ALL_MODULES is
defined. (For example, r307082 relies on seeing the ALL_MODULES symbol
in a sub-make in the modules tree.)

Test Plan

With the change, the ALL_MODULES symbol made it to sub-makes in the modules tree.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5569
Build 5814: arc lint + arc unit

Event Timeline

jtl retitled this revision from to Include ALL_MODULES in MKMODULESENV.
jtl updated this object.
jtl edited the test plan for this revision. (Show Details)
jtl added reviewers: sjg, bdrewery.
imp added a reviewer: imp.

This will just pass it in when it is defined in the kernel config file as a makeconfig option. Otherwise it passes through because it is in the environment, or it isn't defined. No?

This revision is now accepted and ready to land.Jan 27 2017, 12:52 AM
sjg edited edge metadata.

ok

likely good... tagging for srcmgr review if sjg doesn't push or close first.