Page MenuHomeFreeBSD
Differential D8184

Limit stdin in cmp(1).
ClosedPublic
Actions

Authored by oshogbo on Oct 7 2016, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 1, 11:56 PM
Unknown Object (File)
Sun, Nov 23, 10:03 PM
Unknown Object (File)
Thu, Nov 20, 9:52 PM
Unknown Object (File)
Thu, Nov 20, 9:52 PM
Unknown Object (File)
Thu, Nov 20, 9:52 PM
Unknown Object (File)
Thu, Nov 20, 9:43 PM
Unknown Object (File)
Tue, Nov 11, 7:08 AM
Unknown Object (File)
Sun, Nov 9, 4:19 PM
View All 77 Files
Subscribers
None

Details

Reviewers
emaste
cem
allanjude
Commits
rS306820: Restrict stdin if it's not in use.
Summary

If stdin was not choose as one of the input descriptor, limit it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

oshogbo updated this revision to Diff 21159.Oct 7 2016, 6:11 PM
oshogbo retitled this revision from to Limit stdin in cmp(1)..
oshogbo updated this object.
oshogbo edited the test plan for this revision. (Show Details)
oshogbo added reviewers: allanjude, emaste, cem.
cem accepted this revision.Oct 7 2016, 6:28 PM
cem edited edge metadata.
This revision is now accepted and ready to land.Oct 7 2016, 6:28 PM
emaste added inline comments.Oct 7 2016, 6:38 PM
cmp.c
168–169 ↗(On Diff #21159)

FYI you can do this as cap_rights_limit(STDIN_FILENO, cap_rights_init(&rights)) if you're so inclined.

emaste accepted this revision.Oct 7 2016, 6:41 PM
emaste edited edge metadata.
Closed by commit rS306820: Restrict stdin if it's not in use. (authored by oshogbo). · Explain WhyOct 7 2016, 7:02 PM
This revision was automatically updated to reflect the committed changes.
cem added inline comments.Oct 7 2016, 7:55 PM
cmp.c
168–169 ↗(On Diff #21159)

That generally wraps in an ugly way if you're at any indentation at all.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
cmp/
8 lines

Diff 21162

View Options

head/usr.bin/cmp/cmp.c

Loading...