Page MenuHomeFreeBSD

Keep up with the times.
ClosedPublic

Authored by mat on Sep 22 2014, 2:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 8:57 AM
Unknown Object (File)
Feb 9 2024, 3:52 AM
Unknown Object (File)
Dec 19 2023, 9:20 PM
Unknown Object (File)
Nov 26 2023, 3:36 PM
Unknown Object (File)
Nov 8 2023, 4:15 PM
Unknown Object (File)
Nov 6 2023, 7:34 PM
Unknown Object (File)
Nov 5 2023, 10:21 PM
Unknown Object (File)
Nov 5 2023, 3:06 PM
Subscribers

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mat retitled this revision from to Keep up with the times..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: portmgr, Doc Committers.
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Sep 22 2014, 2:30 PM
wblock added inline comments.
en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml
322 ↗(On Diff #1712)

Plural: s/parenthesis/parentheses/

323 ↗(On Diff #1712)

"they" is confusing. Maybe just:
"... or directory referenced."

329 ↗(On Diff #1712)

Break sentence:

"The arguments are optional. If only the group and mode"

330 ↗(On Diff #1712)

s/needs/need/
s/use this/use/

529 ↗(On Diff #1712)

It's not clear what "relative" means here. Does it mean relative to the current permissions, or does it mean the symbolic notation of letters rather than numbers?

605 ↗(On Diff #1712)

s/lives/live/

But "live" is an odd characterization for something that is not alive. "Are stored" is clearer.

766 ↗(On Diff #1712)

This is a poor title. It's not about how to implement @sample, it's about how to use it.

<title>Example: Using <literal>@sample</literal></title>

798 ↗(On Diff #1712)

Do not use contractions. That single quote is problematic in an echo anyway.

[inline]

en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml
322 ↗(On Diff #1712)

That's a comma splice.

330 ↗(On Diff #1712)

"group and mode" is plural, so the plural "need" is correct.

572 ↗(On Diff #1712)

But this should be the singular "needs".

en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml
766 ↗(On Diff #1712)

Ah, no, it *is* about how @sample is implemented, not how to use it. It explains what it does, and then gives the exact code present in the /usr/ports/Keywords/sample.ucl file

798 ↗(On Diff #1712)

Well, it is what is actually in the file, so, unless I change the file, I can't change what's here :-)

mat edited edge metadata.

Correct problems.

mat updated this revision to Diff 1718.

Closed by commit rD45656 (authored by @mat).