Differential D8058

pf: remove fastroute tag
ClosedPublic
Actions

Authored by franco_opnsense.org on Sep 28 2016, 11:33 AM.

Details

Reviewers

Group Reviewers

manpages

Commits

rS306684: pf: remove fastroute tag

Summary

The tag fastroute came from ipf and was removed in OpenBSD in 2011. The code allows to skip the in pfil hooks and completely removes the out pfil invoke, albeit looking up a route that the IP stack will likely find on its own. The code between IPv4 and IPv6 is also inconsistent and marked as "XXX" for years.

Test Plan

fastroute no longer available in pf.conf syntax

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

franco_opnsense.org updated this revision to Diff 20766.Sep 28 2016, 11:33 AM

franco_opnsense.org retitled this revision from to pf: remove fastroute tag.

franco_opnsense.org updated this object.

franco_opnsense.org edited the test plan for this revision. (Show Details)

Herald added a reviewer: manpages. · View Herald TranscriptSep 28 2016, 11:33 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

kp added a subscriber: kp.Sep 28 2016, 1:00 PM

kp added inline comments.

sbin/pfctl/parse.y
451 ↗	(On Diff #20766)	Removing the token will break compatibility with older configurations. Wouldn't it be better to keep the token and ignore it? Existing configurations won't break, and it shouldn't actually change behaviour either.