Remove ifa_list, use ifa_link instead
ClosedPublic
Actions

Authored by kevlo on Sep 27 2016, 1:14 PM.

Details

Reviewers

rrs
tuexen

Commits

rS306407: Remove ifa_list, use ifa_link (structure field) instead.

Summary

There are few source code (only pf and sctp) that use ifa_list.
This patch uses ifa_link (structure field) instead of ifa_list
(macro alias for it) and removes ifa_list.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevlo updated this revision to Diff 20741.Sep 27 2016, 1:14 PM

kevlo retitled this revision from to Remove ifa_list, use ifa_link instead.

kevlo updated this object.

kevlo edited the test plan for this revision. (Show Details)

kevlo added reviewers: rrs, tuexen.

Forgot to mention, prefer if_addrhead (FreeBSD) to if_addrlist (BSD compat)
naming for the interface address list while I'm here.

Drop me a note when you commit it and indicate if you will MFC it.

This revision is now accepted and ready to land.Sep 27 2016, 3:11 PM

Closed by commit rS306407: Remove ifa_list, use ifa_link (structure field) instead. (authored by kevlo). · Explain WhySep 28 2016, 1:29 PM

This revision was automatically updated to reflect the committed changes.

In D8051#166553, @tuexen wrote:

Drop me a note when you commit it and indicate if you will MFC it.

Committed in r306407, thanks.

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

if_var.h

3 lines

netinet/

sctp_bsd_addr.c

4 lines

netpfil/

pf/

pf_if.c

2 lines

Diff 20768

View Options

head/sys/net/if_var.h

View Options

head/sys/netinet/sctp_bsd_addr.c

View Options

head/sys/netpfil/pf/pf_if.c

Remove ifa_list, use ifa_link insteadClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20768

head/sys/net/if_var.h

head/sys/netinet/sctp_bsd_addr.c

head/sys/netpfil/pf/pf_if.c

Remove ifa_list, use ifa_link instead
ClosedPublic
Actions

Revision Contents
Changeset List