Page MenuHomeFreeBSD
Differential D8051

Remove ifa_list, use ifa_link instead
ClosedPublic
Actions

Authored by kevlo on Sep 27 2016, 1:14 PM.
Tags
None
Referenced Files
F153899177: D8051.id20768.diff
Fri, Apr 24, 3:25 PM
F153845511: D8051.id20768.diff
Fri, Apr 24, 5:24 AM
Unknown Object (File)
Thu, Apr 23, 5:30 AM
Unknown Object (File)
Wed, Apr 22, 7:06 PM
Unknown Object (File)
Wed, Apr 22, 12:52 PM
Unknown Object (File)
Tue, Apr 21, 11:12 AM
Unknown Object (File)
Sun, Apr 19, 9:36 PM
Unknown Object (File)
Mon, Apr 6, 7:49 AM
View All Files
Subscribers
None

Details

Reviewers
rrs
tuexen
Commits
rS306407: Remove ifa_list, use ifa_link (structure field) instead.
Summary

There are few source code (only pf and sctp) that use ifa_list.
This patch uses ifa_link (structure field) instead of ifa_list
(macro alias for it) and removes ifa_list.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevlo updated this revision to Diff 20741.Sep 27 2016, 1:14 PM
kevlo retitled this revision from to Remove ifa_list, use ifa_link instead.
kevlo updated this object.
kevlo edited the test plan for this revision. (Show Details)
kevlo added reviewers: rrs, tuexen.
kevlo added a comment.Sep 27 2016, 1:17 PM

Forgot to mention, prefer if_addrhead (FreeBSD) to if_addrlist (BSD compat)
naming for the interface address list while I'm here.

tuexen accepted this revision.Sep 27 2016, 3:11 PM
tuexen edited edge metadata.

Drop me a note when you commit it and indicate if you will MFC it.

This revision is now accepted and ready to land.Sep 27 2016, 3:11 PM
Closed by commit rS306407: Remove ifa_list, use ifa_link (structure field) instead. (authored by kevlo). · Explain WhySep 28 2016, 1:29 PM
This revision was automatically updated to reflect the committed changes.
kevlo added a comment.Sep 28 2016, 1:31 PM
In D8051#166553, @tuexen wrote:

Drop me a note when you commit it and indicate if you will MFC it.

Committed in r306407, thanks.

Revision Contents
Changeset List

PathSize
head/
sys/
net/
3 lines
netinet/
4 lines
netpfil/
pf/
2 lines

Diff 20768

View Options

head/sys/net/if_var.h

Loading...
View Options

head/sys/netinet/sctp_bsd_addr.c

Loading...
View Options

head/sys/netpfil/pf/pf_if.c

Loading...