xpt_action_default XPT_ABORT: protect ccbq access with devq->send_mtx
ClosedPublic
Actions

Authored by rlibby on Sep 20 2016, 11:37 PM.

Details

Reviewers

markj
mav

Commits

rS306061: Protect ccbq access with devq->send_mtx in the XPT_ABORT handler.

Summary

The abort action tries to pluck the ccb from the ccbq, but it was not
taking the necessary lock.

Test Plan

make buildkernel KERNCONF=GENERIC
kyua test -k /usr/tests/sys/Kyuafile

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby updated this revision to Diff 20556.Sep 20 2016, 11:37 PM

rlibby retitled this revision from to xpt_action_default XPT_ABORT: protect ccbq access with devq->send_mtx.

rlibby updated this object.

rlibby edited the test plan for this revision. (Show Details)

rlibby added reviewers: markj, mav.

Herald added a subscriber: imp. · View Herald TranscriptSep 20 2016, 11:37 PM

Looks good to me.

This revision is now accepted and ready to land.Sep 20 2016, 11:48 PM

markj accepted this revision.Sep 20 2016, 11:59 PM

markj edited edge metadata.

Closed by commit rS306061: Protect ccbq access with devq->send_mtx in the XPT_ABORT handler. (authored by markj). · Explain WhySep 21 2016, 12:08 AM

This revision was automatically updated to reflect the committed changes.

rlibby mentioned this in D8151: CAM ccbq sanity: checks on insert & remove.Oct 4 2016, 10:07 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

cam/

cam_xpt.c

20 lines

Diff 20558

View Options

xpt_action_default XPT_ABORT: protect ccbq access with devq->send_mtxClosedPublicActions