Page MenuHomeFreeBSD
Differential D7981

Disable extattr_test on UFS1
ClosedPublic
Actions

Authored by br on Sep 20 2016, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 2:54 AM
Unknown Object (File)
Sat, Feb 15, 12:42 PM
Unknown Object (File)
Thu, Feb 13, 5:58 AM
Unknown Object (File)
Wed, Feb 12, 12:12 AM
Unknown Object (File)
Dec 9 2024, 7:28 AM
Unknown Object (File)
Nov 7 2024, 3:21 AM
Unknown Object (File)
Sep 24 2024, 5:11 PM
Unknown Object (File)
Sep 24 2024, 9:04 AM
View All 88 Files
Subscribers
ngie

Details

Reviewers
ngie
asomers
Group Reviewers
tests
Commits
rS306093: Disable extattr test on UFS1.
Summary

only UFS2 uses native extended attributes

UFS1 supports extended attrs, but not natively and requires additional commands to run, which is not supported by this test

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br updated this revision to Diff 20543.Sep 20 2016, 4:44 PM
br retitled this revision from to Disable extattr_test on UFS1.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added reviewers: tests, asomers.
asomers accepted this revision.Sep 20 2016, 4:55 PM
asomers edited edge metadata.

LGTM. Though I shudder to think of where you found a UFS1 file system.

This revision is now accepted and ready to land.Sep 20 2016, 4:55 PM
ngie accepted this revision.Sep 20 2016, 5:34 PM
ngie added a reviewer: ngie.
ngie added a subscriber: ngie.
ngie added inline comments.
usr.sbin/extattr/tests/extattr_test.sh
358–362 ↗(On Diff #20543)

It would be nice if this was dumped out by tunefs -p.. I'll see about doing that.

ngie added a comment.EditedSep 20 2016, 5:36 PM
In D7981#165006, @asomers wrote:

LGTM. Though I shudder to think of where you found a UFS1 file system.

MIPS* embedded installs (and some ARM64 installs) use it with CF/flash cards from what I gather (I think to reduce wear leveling?).

br added a comment.Sep 21 2016, 9:47 AM
In D7981#165006, @asomers wrote:

LGTM. Though I shudder to think of where you found a UFS1 file system.

makefs creates UFS1 by default

Closed by commit rS306093: Disable extattr test on UFS1. (authored by br). · Explain WhySep 21 2016, 10:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
extattr/
tests/
6 lines

Diff 20576

View Options

head/usr.sbin/extattr/tests/extattr_test.sh

Loading...