Page MenuHomeFreeBSD

ukbd(4): Support for input event interface
ClosedPublic

Authored by wulf_cicgroup.ru on Sep 19 2016, 11:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 10:23 AM
Unknown Object (File)
Feb 21 2024, 6:48 PM
Unknown Object (File)
Feb 21 2024, 6:48 PM
Unknown Object (File)
Feb 21 2024, 6:48 PM
Unknown Object (File)
Feb 21 2024, 6:35 PM
Unknown Object (File)
Feb 11 2024, 12:46 PM
Unknown Object (File)
Dec 20 2023, 1:26 AM
Unknown Object (File)
Dec 17 2023, 4:41 PM

Details

Summary

Adds support for input event interface in ukbd(4) driver

At present time evdev module is tuned to prefer sysmouse and kbdmux event devices so ukbd`s eventX cdev will be silent until sysctl kern.evdev.rcpt_mask=12 is executed

Known bug: Keymap reading/writing is not implemented
Last minor change (checking evdev pointer for NULL before event pushing) has not been tested "in hardware".

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf_cicgroup.ru retitled this revision from to ukbd(4): Support for input event interface.
wulf_cicgroup.ru updated this object.
wulf_cicgroup.ru edited the test plan for this revision. (Show Details)
wulf_cicgroup.ru set the repository for this revision to rS FreeBSD src repository - subversion.
hselasky edited edge metadata.
hselasky added inline comments.
sys/dev/usb/input/ukbd.c
367 ↗(On Diff #20509)

Should this structure be "static const" instead of "static" ?

This revision is now accepted and ready to land.Sep 20 2016, 5:10 PM
sys/dev/usb/input/ukbd.c
367 ↗(On Diff #20509)

evdev_set_methods accepts non-const pointer, it probably should be fixed in evdev API. I'll commit this patch as-is and we'll fix it along with dev/evdev

This revision was automatically updated to reflect the committed changes.

For reasons unclear to me FreeBSD does not use const modifier in similar cases. Grep sources for e.g. struct fileops, struct vop_vector, struct cdevsw, struct filterops declarations.

For reasons unclear to me FreeBSD does not use const modifier in similar cases. Grep sources for e.g. struct fileops, struct vop_vector, struct cdevsw, struct filterops declarations.

All the examples you quoted, with the possible exception of filterops, predate wide-spread compiler support for const and simply haven't been updated.