bspatch: Remove backwards-compatibility sys/capability.h support
ClosedPublic
Actions

Authored by emaste on Sep 19 2016, 3:44 PM.

Details

Reviewers

allanjude
oshogbo

Commits

rS306026: bspatch: Remove backwards-compatibility sys/capability.h support

Summary

bspatch previously included sys/capability.h or sys/capsicum.h based on __FreeBSD_version, as FreeBSD is the upstream for bsdiff and we may encounter this file again when incorporated into other third-party software.

The Capsicum header is now installed as sys/capsicum.h in stable/10 and FreeBSD 10.3, so we can just enable capsicum only there and simplify the logic.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 20488.Sep 19 2016, 3:44 PM

emaste retitled this revision from to bspatch: Remove backwards-compatibility sys/capability.h support.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: allanjude, oshogbo.

Note that stable/9 and FreeBSD 9.3, 10.1, and 10.2 all have an expected EoL of Dec 31 2016, so I think it's unlikely that this file will loop back to us on a supported branch that lacks sys/capsicum.h.

emaste added a subscriber: cem.Sep 20 2016, 1:10 PM

allanjude accepted this revision.Sep 20 2016, 2:57 PM

allanjude edited edge metadata.

This revision is now accepted and ready to land.Sep 20 2016, 2:57 PM

Closed by commit rS306026: bspatch: Remove backwards-compatibility sys/capability.h support (authored by emaste). · Explain WhySep 20 2016, 3:13 PM

This revision was automatically updated to reflect the committed changes.