Page MenuHomeFreeBSD
Differential D789

vt(4): Use vt_fb_drawrect() and vt_fb_setpixel() in all vt_fb-derivative
ClosedPublic
Actions

Authored by dumbbell on Sep 16 2014, 5:47 PM.
Tags
None
Referenced Files
F153498124: D789.diff
Tue, Apr 21, 11:42 AM
Unknown Object (File)
Sun, Apr 12, 6:01 AM
Unknown Object (File)
Sun, Apr 5, 9:27 PM
Unknown Object (File)
Sun, Apr 5, 5:48 AM
Unknown Object (File)
Mar 19 2026, 9:18 AM
Unknown Object (File)
Mar 9 2026, 7:24 AM
Unknown Object (File)
Feb 28 2026, 8:46 AM
Unknown Object (File)
Jan 4 2026, 10:08 AM
View All Files
Subscribers
None

Details

Reviewers
ray
nwhitehorn
emaste
Summary

Without this, one could see margins in an unexpected color when using a screen and/or a font with a non-multiple-of-8 width.

This was reported by bz@, but he didn't had time to test it yet. This is only compile-tested, as I have no use of the affected backends, though, I believe this is ok.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dumbbell updated this revision to Diff 1648.Sep 16 2014, 5:47 PM
dumbbell retitled this revision from to vt(4): Use vt_fb_drawrect() and vt_fb_setpixel() in all vt_fb-derivative.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: emaste, ray, nwhitehorn.
nwhitehorn accepted this revision.Sep 16 2014, 5:56 PM
nwhitehorn edited edge metadata.

Looks good!

This revision is now accepted and ready to land.Sep 16 2014, 5:56 PM
dumbbell closed this revision.Sep 16 2014, 6:02 PM

Thank you!

Committed in r271684.

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
hw/
efifb/
2 lines
fb/
2 lines
2 lines
7 lines
powerpc/
ps3/
2 lines

Diff 1648

View Options

sys/dev/vt/hw/efifb/efifb.c

Loading...
View Options

sys/dev/vt/hw/fb/vt_early_fb.c

Loading...
View Options

sys/dev/vt/hw/fb/vt_fb.h

Loading...
View Options

sys/dev/vt/hw/fb/vt_fb.c

Loading...
View Options

sys/powerpc/ps3/ps3_syscons.c

Loading...