Page MenuHomeFreeBSD
Differential D7888

Remove 'cpu' and 'cpu_class' on amd64.
ClosedPublic
Actions

Authored by jhb on Sep 13 2016, 11:05 PM.
Tags
None
Referenced Files
F161819088: D7888.id20370.diff
Tue, Jul 7, 3:04 AM
Unknown Object (File)
Fri, Jul 3, 9:00 PM
Unknown Object (File)
Mon, Jun 29, 2:17 PM
Unknown Object (File)
Sat, Jun 20, 3:34 PM
Unknown Object (File)
Sat, Jun 20, 1:24 AM
Unknown Object (File)
Fri, Jun 12, 8:02 PM
Unknown Object (File)
May 7 2026, 11:07 AM
Unknown Object (File)
May 6 2026, 5:46 AM
View All Files
Subscribers
imp
rpokala

Details

Reviewers
kib
imp
Commits
rS305836: Remove 'cpu' and 'cpu_class' on amd64.
Summary

Remove 'cpu' and 'cpu_class' on amd64.

The 'cpu' and 'cpu_class' variables were always set to the same value
on amd64 and are legacy holdovers from i386. Remove them entirely on
amd64.

Test Plan
  • universe build
  • boot amd64 kernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 20328.Sep 13 2016, 11:05 PM
jhb retitled this revision from to Remove 'cpu' and 'cpu_class' on amd64..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
Herald added subscribers: rpokala, imp. · View Herald TranscriptSep 13 2016, 11:05 PM
imp accepted this revision.Sep 13 2016, 11:15 PM
imp added a reviewer: imp.
This revision is now accepted and ready to land.Sep 13 2016, 11:15 PM
kib accepted this revision.Sep 14 2016, 10:26 AM
kib edited edge metadata.
jhb updated this revision to Diff 20369.Sep 15 2016, 4:39 PM
jhb edited edge metadata.
  • Rebase
  • Move 'cpu' and 'cpu_class' into i386 cputypes.h.
  • Ensure cpu_model is initialized on amd64.
This revision now requires review to proceed.Sep 15 2016, 4:39 PM
Closed by commit rS305836: Remove 'cpu' and 'cpu_class' on amd64. (authored by jhb). · Explain WhySep 15 2016, 5:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
1 line
include/
46 lines
compat/
linprocfs/
31 lines
i386/
include/
5 lines
1 line
x86/
include/
5 lines
1 line
x86/
43 lines

Diff 20370

View Options

head/sys/amd64/amd64/machdep.c

Loading...
View Options

head/sys/amd64/include/cputypes.h

Loading...
View Options

head/sys/compat/linprocfs/linprocfs.c

Loading...
View Options

head/sys/i386/include/cputypes.h

Loading...
View Options

head/sys/i386/include/md_var.h

Loading...
View Options

head/sys/x86/include/cputypes.h

Loading...
View Options

head/sys/x86/include/x86_var.h

Loading...
View Options

head/sys/x86/x86/identcpu.c

Loading...