Page MenuHomeFreeBSD

math/galculator: Update to 2.1.4
ClosedPublic

Authored by woodsb02 on Sep 5 2016, 2:16 PM.

Details

Summary

math/galculator: Update to 2.1.4

  • Follow upstream move from SF to GitHub, and new website hosting
  • Add USES=autoreconf libtool as GH tarball only comes with configure.ac
  • Add OPTION for GTK3 instead of GTK2 (on by default as per upstream)
  • Add USE_GNOME=cairo undeclared dependency, detected by stage-qa script

Changes this release:

https://github.com/galculator/galculator/blob/v2.1.4/ChangeLog
Test Plan

poudriere testport: Tested ok on 10amd64, 12amd64, 9i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

woodsb02 retitled this revision from to math/galculator: Update to 2.1.4.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, mat, koobs, naddy.
math/galculator/Makefile
24 ↗(On Diff #20058)

You should probably add a GTK3_DESC to make it clear that you can get GTK2 by turning the knob off.

Also, because this changes the default, you might consider a head's up in UPDATING.

math/galculator/pkg-descr
1 ↗(On Diff #20058)

"GTK2-based" is no longer accurate here... consider "GTK-based" instead.

math/galculator/Makefile
23–24 ↗(On Diff #20058)

This should be an OPTIONS_SINGLE group, GTK2/GTK3. Because here, the user is presented with a single option, "GTK+ 3 GUI toolkit support"

The GTK3 block afterwards is good, as it will work the same if GTK2 is selected.

  • Add UPDATING entry
  • Add OPTIONS_SINGLE for GTK2 and GTK3
mat edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2016, 7:54 AM

Waiting on feedback from naddy as maintainer

naddy edited edge metadata.

This is great, thanks.

This revision was automatically updated to reflect the committed changes.