cron: use existing maximum username constant MAXLOGNAME
ClosedPublic
Actions

Authored by emaste on Sep 1 2016, 3:49 PM.

Details

Reviewers

jilles
allanjude
delphij

Commits

rS305269: cron: use existing maximum username constant MAXLOGNAME

Summary

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212305

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 19943.Sep 1 2016, 3:49 PM

emaste retitled this revision from to cron: use existing maximum username constant MAXLOGNAME.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: allanjude, delphij, jilles.

seems reasonable.

This revision is now accepted and ready to land.Sep 1 2016, 4:38 PM

Perhaps it would be even better to use strdup() instead of fixed-length buffers but for a part of FreeBSD that is not very important. This change in this review is important and fixes a real problem.

Closed by commit rS305269: cron: use existing maximum username constant MAXLOGNAME (authored by emaste). · Explain WhySep 2 2016, 3:16 AM

This revision was automatically updated to reflect the committed changes.

Perhaps it would be even better to use strdup() instead of fixed-length buffers but for a part of FreeBSD that is not very important. This change in this review is important and fixes a real problem.

Yes, cron deserves careful review and probably improvements such as that, but I agree that it's important to get the immediate problem fixed.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

cron/

cron.h

1 line

crontab/

crontab.c

3 lines

Diff 19962

View Options

head/usr.sbin/cron/cron/cron.h