Page MenuHomeFreeBSD

cron: use existing maximum username constant MAXLOGNAME
ClosedPublic

Authored by emaste on Sep 1 2016, 3:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 29, 9:26 AM
Unknown Object (File)
Sun, Sep 28, 8:38 PM
Unknown Object (File)
Sep 1 2025, 3:52 AM
Unknown Object (File)
Aug 30 2025, 3:16 PM
Unknown Object (File)
Aug 14 2025, 10:29 AM
Unknown Object (File)
Aug 6 2025, 2:50 PM
Unknown Object (File)
Aug 5 2025, 1:44 AM
Unknown Object (File)
Aug 4 2025, 1:38 PM
Subscribers
None

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to cron: use existing maximum username constant MAXLOGNAME.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: allanjude, delphij, jilles.
allanjude edited edge metadata.

seems reasonable.

This revision is now accepted and ready to land.Sep 1 2016, 4:38 PM
jilles edited edge metadata.

Perhaps it would be even better to use strdup() instead of fixed-length buffers but for a part of FreeBSD that is not very important. This change in this review is important and fixes a real problem.

This revision was automatically updated to reflect the committed changes.

Perhaps it would be even better to use strdup() instead of fixed-length buffers but for a part of FreeBSD that is not very important. This change in this review is important and fixes a real problem.

Yes, cron deserves careful review and probably improvements such as that, but I agree that it's important to get the immediate problem fixed.