Page MenuHomeFreeBSD

Update archivers/quazip and archivers/quazip-qt5 to 0.7.2
ClosedPublic

Authored by tcberner on Aug 31 2016, 9:11 PM.

Details

Summary
  • archivers/quazip
    • Regenerate the qztest.pro patch for archivers/quazip
  • archivers/quazip-qt5
    • Drop the coinstallability patch as it is now part of the release
    • Add a patch to pass -fPIC
Test Plan
Tested on 12-current and 10.3.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner retitled this revision from to Update archivers/quazip and archivers/quazip-qt5 to 0.7.2.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: nivit, rakuco.
archivers/quazip-qt5/Makefile
15 ↗(On Diff #19891)

Not really related to this review request, but you might take the opportunity to change this to cmake:outsource.

archivers/quazip-qt5/files/patch-CMakeLists.txt
9 ↗(On Diff #19891)

This is too generic and is only required by the quazip_static target (CMake automatically passes -fPIC when building shared libraries).

It's a bug in quazip's build system, and I've sent a patch upstream that you might want to use: https://sourceforge.net/p/quazip/patches/28/

Is there a reason one of those port is not a slave of the other ?

In D7726#161715, @mat wrote:

Is there a reason one of those port is not a slave of the other ?

Not really, it's just that nivit@ created and maintains archivers/quazip, and kde@ later added archivers/quazip-qt5, and both use different build systems.

tcberner edited edge metadata.
  • Switch to cmake:outsource
  • Add Raphaels patch

Mark stuff done.

rakuco edited edge metadata.

The quazip-qt5 side looks ok, just remember that the patch should be called patch-quazip_CMakeLists.txt instead.

Ping @nivit

This revision is now accepted and ready to land.Sep 6 2016, 7:02 PM
This revision was automatically updated to reflect the committed changes.