- archivers/quazip
- Regenerate the qztest.pro patch for archivers/quazip
- archivers/quazip-qt5
- Drop the coinstallability patch as it is now part of the release
- Add a patch to pass -fPIC
Details
Details
Tested on 12-current and 10.3.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
archivers/quazip-qt5/Makefile | ||
---|---|---|
15 ↗ | (On Diff #19891) | Not really related to this review request, but you might take the opportunity to change this to cmake:outsource. |
archivers/quazip-qt5/files/patch-CMakeLists.txt | ||
9 ↗ | (On Diff #19891) | This is too generic and is only required by the quazip_static target (CMake automatically passes -fPIC when building shared libraries). It's a bug in quazip's build system, and I've sent a patch upstream that you might want to use: https://sourceforge.net/p/quazip/patches/28/ |
Comment Actions
Not really, it's just that nivit@ created and maintains archivers/quazip, and kde@ later added archivers/quazip-qt5, and both use different build systems.
Comment Actions
The quazip-qt5 side looks ok, just remember that the patch should be called patch-quazip_CMakeLists.txt instead.
Ping @nivit