Page MenuHomeFreeBSD

astro/google-earth: Update to 7.1.5.1557
ClosedPublic

Authored by woodsb02 on Aug 28 2016, 1:43 PM.

Details

Summary

astro/google-earth: Update to 7.1.5.1557

  • Switch to USES=makeself to minimize Makefile
  • Improve COMMENT and pkg-descr, to clarify exactly what this port provides
  • Do not set WRKSRC, as the default works just fine
  • Fix whitespace at the end of LINUX_DRI_DESC (pet portlint)
  • Install files with COPYTREE_SHARE instead of CP, to ensure permissions are set correctly
  • Remove redundant -f after ${RM}

Changes this release:

http://www.gearthblog.com/blog/archives/2015/05/new-version-google-earth-7-1-5.html
Test Plan

poudriere testport astro/google-earth

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

woodsb02 updated this revision to Diff 19756.Aug 28 2016, 1:43 PM
woodsb02 retitled this revision from to astro/google-earth: Update to 7.1.5.1557.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, mat, koobs.
adamw added inline comments.Aug 28 2016, 3:02 PM
astro/google-earth/Makefile
37 ↗(On Diff #19756)

tar arguments should always have dashes. If users have ${TAR} redefined to anything else, using bare xf will cause it to break.

As an example:

$ tar -v xf foo.tar
tar: Must specify one of -c, -r, -t, -u, -x

While here, you can reduce the compound into

${TAR} -C ${WRKSRC} -xf google[...]
mat added inline comments.Aug 28 2016, 6:52 PM
astro/google-earth/Makefile
67 ↗(On Diff #19756)

Changing from CP to COPYTREE_SHARE is a great step.

Just make sure there are no files that need to be executable or something in there, like, maybe, googleearth :-)

woodsb02 updated this revision to Diff 19791.Aug 29 2016, 12:54 PM
  • Ensure ${TAR} arguments have dashes
  • Ensure binaries are executable by installing with ${INSTALL_PROGRAM}
woodsb02 marked 2 inline comments as done.Aug 29 2016, 12:56 PM
woodsb02 added inline comments.
astro/google-earth/Makefile
37 ↗(On Diff #19756)

I did add the dashes, but I did not compound this because it would need to be longer.

Instead of:
@cd ${WRKSRC} && ${TAR} -xf googleearth-linux-x86.tar && ${RM} googleearth-linux-x86.tar

It would have to be:
${TAR} -C ${WRKSRC} -xf ${WRKSRC}/googleearth-linux-x86.tar && ${RM} ${WRKSRC}/googleearth-linux-x86.tar

mat accepted this revision.Aug 29 2016, 1:31 PM
mat edited edge metadata.

Looks good to me

This revision is now accepted and ready to land.Aug 29 2016, 1:31 PM
This revision was automatically updated to reflect the committed changes.
woodsb02 marked an inline comment as done.