Page MenuHomeFreeBSD

astro/google-earth: Update to

Authored by woodsb02 on Aug 28 2016, 1:43 PM.
Referenced Files
Unknown Object (File)
Dec 29 2023, 4:55 PM
Unknown Object (File)
Dec 29 2023, 4:55 PM
Unknown Object (File)
Dec 29 2023, 4:55 PM
Unknown Object (File)
Dec 29 2023, 4:55 PM
Unknown Object (File)
Dec 29 2023, 4:44 PM
Unknown Object (File)
Dec 20 2023, 12:16 AM
Unknown Object (File)
Dec 11 2023, 1:34 AM
Unknown Object (File)
Nov 10 2023, 4:32 AM



astro/google-earth: Update to

  • Switch to USES=makeself to minimize Makefile
  • Improve COMMENT and pkg-descr, to clarify exactly what this port provides
  • Do not set WRKSRC, as the default works just fine
  • Fix whitespace at the end of LINUX_DRI_DESC (pet portlint)
  • Install files with COPYTREE_SHARE instead of CP, to ensure permissions are set correctly
  • Remove redundant -f after ${RM}

Changes this release:
Test Plan

poudriere testport astro/google-earth

Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

woodsb02 retitled this revision from to astro/google-earth: Update to
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, mat, koobs.
37 ↗(On Diff #19756)

tar arguments should always have dashes. If users have ${TAR} redefined to anything else, using bare xf will cause it to break.

As an example:

$ tar -v xf foo.tar
tar: Must specify one of -c, -r, -t, -u, -x

While here, you can reduce the compound into

${TAR} -C ${WRKSRC} -xf google[...]
67 ↗(On Diff #19756)

Changing from CP to COPYTREE_SHARE is a great step.

Just make sure there are no files that need to be executable or something in there, like, maybe, googleearth :-)

  • Ensure ${TAR} arguments have dashes
  • Ensure binaries are executable by installing with ${INSTALL_PROGRAM}
woodsb02 added inline comments.
37 ↗(On Diff #19756)

I did add the dashes, but I did not compound this because it would need to be longer.

Instead of:
@cd ${WRKSRC} && ${TAR} -xf googleearth-linux-x86.tar && ${RM} googleearth-linux-x86.tar

It would have to be:
${TAR} -C ${WRKSRC} -xf ${WRKSRC}/googleearth-linux-x86.tar && ${RM} ${WRKSRC}/googleearth-linux-x86.tar

mat edited edge metadata.

Looks good to me

This revision is now accepted and ready to land.Aug 29 2016, 1:31 PM
This revision was automatically updated to reflect the committed changes.
woodsb02 marked an inline comment as done.