Page MenuHomeFreeBSD

Use LIB_DEPENDS when appropriate.
ClosedPublic

Authored by mat on Aug 24 2016, 11:48 AM.

Details

Summary

Lots of KDE components are providing libraries, and they were,
strangely, written as BUILD_ or RUN_DEPENDS, with a full path to the
library. Change this so that if a component is needed at both build,
and, run-time, then it gets a LIB_DEPENDS.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat retitled this revision from to Use LIB_DEPENDS when appropriate..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: kde.
rakuco added a reviewer: rakuco.
rakuco added a subscriber: rakuco.

Looks fine to me. I'm pretty sure we can drop the absolute paths from all <component>_PATHs that are not runtime dependencies by default and simplify that dependency logic, but that can be done separately in the future and probably requires an exp-run.

tcberner added a reviewer: tcberner.
tcberner added a subscriber: tcberner.

Looks fine to me.

tcberner edited edge metadata.

editors/kate-plugin-pate fails to build:
Error: pattern kde4/kpythonpluginfactory.so in LIB_DEPENDS is not valid

This revision now requires changes to proceed.Aug 24 2016, 6:08 PM

editors/kate-plugin-pate fails to build:
Error: pattern kde4/kpythonpluginfactory.so in LIB_DEPENDS is not valid

I knew it was too easy :-)

mat edited edge metadata.
  • Try something else.
  • And now for something completely different.
  • Add the KDE libs to the proxydeps thingie.
mat edited edge metadata.
  • There are a few qt components that ends in -qtX instead of starting with
In D7625#158835, @mat wrote:
  • There are a few qt components that ends in -qtX instead of starting with

They should've been renamed to qtX-foo a long time ago, if you ask me.

tcberner edited edge metadata.

From what I have tested it seems fine.

This revision was automatically updated to reflect the committed changes.