Differential D7464

Fix building btxldr with BTXLDR_VERBOSE
ClosedPublic
Actions

Authored by stevek on Aug 10 2016, 11:41 PM.

Details

Reviewers

jhb

Commits

rS303962: Add the missing space between .asciz directive and opening quote for some

Summary

Add the missing space between .asciz directive and opening quote for some lines within #ifdef BTXLDR_VERBOSE/#endif

Test Plan

BTXLDR_VERBOSE was being used to track down some issues with ISO image based
installer at Juniper and the compilation failed without the change. Everything
worked much better after adding the requisite space.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stevek updated this revision to Diff 19190.Aug 10 2016, 11:41 PM

stevek retitled this revision from to Fix building btxldr with BTXLDR_VERBOSE.

stevek updated this object.

stevek edited the test plan for this revision. (Show Details)

stevek added a reviewer: jhb.

Herald added a subscriber: imp. · View Herald TranscriptAug 10 2016, 11:41 PM

Huh, I've definitely used BTXLDR_VERBOSE in the past, but probably in the 4.x/5.0-CURRENT days with older binutils.

This revision is now accepted and ready to land.Aug 11 2016, 5:02 AM

Closed by commit rS303962: Add the missing space between .asciz directive and opening quote for some (authored by stevek). · Explain WhyAug 11 2016, 3:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

i386/

btx/

btxldr/

btxldr.S

12 lines

Diff 19207

View Options

head/sys/boot/i386/btx/btxldr/btxldr.S

Fix building btxldr with BTXLDR_VERBOSEClosedPublicActions