Make cpu_set_user_tls() work when called on the running thread
ClosedPublic
Actions

Authored by ed on Aug 8 2016, 10:49 AM.

Details

Reviewers

andrew
imp

Commits

rS304148: MFC r303923:
rS303923: Make cpu_set_user_tls() work when called on the running thread.

Summary

On all the other architectures, this function can also be called on the currently running thread. In this case, we shouldn't fix up the address in the PCB, but also patch up the register itself. Otherwise it will not become active and will simply become overwritten by the next switch.

Test Plan

This unbreaks CloudABI support on aarch64 for me.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ed updated this revision to Diff 19116.Aug 8 2016, 10:49 AM

ed retitled this revision from to Make cpu_set_user_tls() work when called on the running thread.

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added a reviewer: andrew.

ed set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: emaste, imp. · View Herald TranscriptAug 8 2016, 10:49 AM

Looks good to my eye, based on what I know from my MIPS days, but consider this a weak 'yes'

This revision is now accepted and ready to land.Aug 10 2016, 3:39 PM

Closed by commit rS303923: Make cpu_set_user_tls() work when called on the running thread. (authored by ed). · Explain WhyAug 10 2016, 3:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

vm_machdep.c

2 lines

Diff 19179

View Options

head/sys/arm64/arm64/vm_machdep.c

Make cpu_set_user_tls() work when called on the running threadClosedPublicActions