Differential D7397

Apply the fix from r232612 to fixed function counters.
ClosedPublic
Actions

Authored by jhb on Aug 2 2016, 6:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Nov 19 2024, 4:51 AM

	Unknown Object (File)
	Nov 14 2024, 10:55 PM

	Unknown Object (File)
	Sep 30 2024, 7:35 PM

	Unknown Object (File)
	Sep 18 2024, 12:12 PM

	Unknown Object (File)
	Sep 18 2024, 12:12 PM

	Unknown Object (File)
	Sep 18 2024, 12:12 PM

	Unknown Object (File)
	Sep 18 2024, 12:00 PM

	Unknown Object (File)
	Sep 17 2024, 12:53 AM

View All 31 Files

Subscribers

Details

Reviewers

emaste
gnn

Commits

rS303720: Apply the fix from r232612 to fixed function counters.

Summary

Apply the fix from r232612 to fixed function counters.

Test Plan

I ran several pmcstat counting invocations on a testbox (fox2 in the netperf lab) but was never able to reproduce the type of brokenness that was fixed by r232612. I didn't see any regressions and this is correct by my reading of SDM, I just didn't see any upper bits set in the PMC MSR during testing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 18962.Aug 2 2016, 6:25 PM

jhb retitled this revision from to Apply the fix from r232612 to fixed function counters..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: emaste, gnn.

Herald added a subscriber: imp. · View Herald TranscriptAug 2 2016, 6:25 PM

Handy link to mentioned commit: rS232612

This seems fine to me.

This revision is now accepted and ready to land.Aug 2 2016, 7:02 PM

Closed by commit rS303720: Apply the fix from r232612 to fixed function counters. (authored by jhb). · Explain WhyAug 3 2016, 4:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hwpmc/

2 lines

Diff 19004

head/sys/dev/hwpmc/hwpmc_core.c

Loading...