Page MenuHomeFreeBSD

[iwm] Use iwm_mvm_scan_stop_wait to properly abort scans.
AcceptedPublic

Authored by ivadasz on Jul 27 2016, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 1:17 AM
Unknown Object (File)
Dec 2 2023, 4:29 PM
Unknown Object (File)
Jul 4 2023, 5:54 AM
Unknown Object (File)
Jun 25 2023, 12:15 PM
Unknown Object (File)
Jun 21 2023, 5:20 PM
Unknown Object (File)
May 11 2023, 4:30 PM
Unknown Object (File)
May 5 2023, 10:44 PM
Unknown Object (File)
May 3 2023, 7:34 AM
Subscribers

Details

Reviewers
cognet
adrian
Summary
  • Add IWM_FLAG_SCAN_RUNNING to sc->sc_flags to track whether the firmware is currently running a scan, in order to decide wheter iwm_scan_end needs to abort a running scan.
  • In iwm_scan_end, if the scan is still running, we now abort it, in order to keep the firmware scanning state in sync.
  • Try to make things a bit simpler, by reacting on the IWM_SCAN_OFFLOAD_COMPLETE and IWM_SCAN_COMPLETE_UMAC notifications, instead of IWM_SCAN_ITERATION_COMPLETE and IWM_SCAN_ITERATION_COMPLETE_UMAC. This should be fine since we always only tell the firmware to do a single scan iteration anyway.
  • With this change, I can start multiple scan request via "ifconfig wlan0 scan" in quick succession without triggering a firmware panic as before this change.
Test Plan

AC3165, STA mode

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4639
Build 4693: arc lint + arc unit

Event Timeline

ivadasz retitled this revision from to [iwm] Use iwm_mvm_scan_stop_wait to properly abort scans..
ivadasz updated this object.
ivadasz edited the test plan for this revision. (Show Details)
ivadasz added reviewers: adrian, cognet.
adrian edited edge metadata.

looks good! thanks!

This revision is now accepted and ready to land.Jul 28 2016, 2:20 AM