[iwm] Add scan abort functions, to properly cancel a running scan.
ClosedPublic
Actions

Authored by ivadasz on Jul 27 2016, 10:26 PM.

Details

Reviewers

cognet
adrian

Summary

This adds the scan abort functions to if_iwm_scan.c, but doesn't use them yet.

Use the notification wait api to wait for the corresponding scan complete notification after sending the abort command.

Obtained from: Linux iwlwifi

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4638
Build 4692: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 18829.Jul 27 2016, 10:26 PM

ivadasz retitled this revision from to [iwm] Add scan abort functions, to properly cancel a running scan..

ivadasz updated this object.

ivadasz edited the test plan for this revision. (Show Details)

ivadasz added reviewers: adrian, cognet.

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2016, 10:26 PM

ivadasz added a child revision: D7342: [iwm] Use iwm_mvm_scan_stop_wait to properly abort scans..Jul 27 2016, 10:33 PM

ivadasz added a parent revision: D7340: [iwm] Add partial implementation of notification wait api from iwlwifi..

adrian accepted this revision.Jul 28 2016, 2:21 AM

adrian edited edge metadata.

adrian added inline comments.

sys/dev/iwm/if_iwm_scan.c
813	ugh, I really hate this. Is there any way we can have the wait notification thing take the lock so it can atomically unlock/sleep or something? (But not in this patch, we can fix it later.)

This revision is now accepted and ready to land.Jul 28 2016, 2:21 AM

Already in tree.

commit 4b17c188825d8adcc5449374da0199e825c0149a
Author: Adrian Chadd <adrian@FreeBSD.org>
Date:   Wed Feb 8 06:44:50 2017 +0000

  [iwm] Add scan abort functions, to properly cancel a running scan.

  * Uses the notification wait api to wait for the corresponding scan
    complete notification after sending the abort command.

  Taken-From: Linux iwlwifi

  Obtained from:  DragonflyBSD commit b484d09d54301740f036ddf02008117f563960c2