[iwm] Fix inverted logic in iwm_tx().
ClosedPublic
Actions

Authored by ivadasz on Jul 26 2016, 9:44 PM.

Tags

None

Referenced Files

	F132958197: D7323.id18777.diff
	Tue, Oct 21, 1:16 PM

	Unknown Object (File)
	Mon, Oct 20, 10:26 PM

	Unknown Object (File)
	Sun, Oct 12, 3:11 PM

	Unknown Object (File)
	Fri, Oct 10, 12:27 AM

	Unknown Object (File)
	Thu, Oct 2, 2:21 PM

	Unknown Object (File)
	Tue, Sep 30, 12:20 AM

	Unknown Object (File)
	Sep 4 2025, 3:57 AM

	Unknown Object (File)
	Sep 2 2025, 7:28 PM

View All Files

Subscribers

imp

Details

Reviewers

cognet
sbruno
adrian

Commits

rS303413: [iwm] Fix inverted logic in iwm_tx().

Summary

The PROT_REQUIRE flag in should be set for data frames above a certain
length, but we were setting it for !data frames above a certain length,
which makes no sense at all.

Taken-From: OpenBSD, Linux iwlwifi

Obtained from: DragonFlyBSD git 8cc03924a36c572c2908e659e624f44636dc2b33

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4625
Build 4678: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 18777.Jul 26 2016, 9:44 PM

ivadasz retitled this revision from to [iwm] Fix inverted logic in iwm_tx()..

ivadasz updated this object.

ivadasz edited the test plan for this revision. (Show Details)

ivadasz added reviewers: adrian, cognet, sbruno.

Herald added a subscriber: imp. · View Herald TranscriptJul 26 2016, 9:44 PM

adrian accepted this revision.Jul 26 2016, 10:20 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Jul 26 2016, 10:20 PM

Closed by commit rS303413: [iwm] Fix inverted logic in iwm_tx(). (authored by ivadasz). · Explain WhyJul 27 2016, 8:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

iwm/

if_iwm.c

2 lines

Diff 18777

View Options

[iwm] Fix inverted logic in iwm_tx().ClosedPublicActions