Page MenuHomeFreeBSD
Differential D7323

[iwm] Fix inverted logic in iwm_tx().
ClosedPublic
Actions

Authored by ivadasz on Jul 26 2016, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 4:34 AM
Unknown Object (File)
May 7 2024, 11:28 PM
Unknown Object (File)
May 5 2024, 8:10 PM
Unknown Object (File)
Apr 26 2024, 6:09 AM
Unknown Object (File)
Apr 4 2024, 4:06 PM
Unknown Object (File)
Apr 2 2024, 4:33 AM
Unknown Object (File)
Apr 2 2024, 4:32 AM
Unknown Object (File)
Feb 28 2024, 4:36 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
cognet
sbruno
adrian
Commits
rS303413: [iwm] Fix inverted logic in iwm_tx().
Summary
The PROT_REQUIRE flag in should be set for data frames above a certain
length, but we were setting it for !data frames above a certain length,
which makes no sense at all.

Taken-From: OpenBSD, Linux iwlwifi

Obtained from: DragonFlyBSD git 8cc03924a36c572c2908e659e624f44636dc2b33

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivadasz updated this revision to Diff 18777.Jul 26 2016, 9:44 PM
ivadasz retitled this revision from to [iwm] Fix inverted logic in iwm_tx()..
ivadasz updated this object.
ivadasz edited the test plan for this revision. (Show Details)
ivadasz added reviewers: adrian, cognet, sbruno.
Herald added a subscriber: imp. · View Herald TranscriptJul 26 2016, 9:44 PM
adrian accepted this revision.Jul 26 2016, 10:20 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 10:20 PM
Closed by commit rS303413: [iwm] Fix inverted logic in iwm_tx(). (authored by ivadasz). · Explain WhyJul 27 2016, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwm/
2 lines

Diff 18824

View Options

head/sys/dev/iwm/if_iwm.c

Loading...