Page MenuHomeFreeBSD
Differential D7323

[iwm] Fix inverted logic in iwm_tx().
ClosedPublic
Actions

Authored by ivadasz on Jul 26 2016, 9:44 PM.
Tags
None
Referenced Files
F136897507: D7323.id18824.diff
Thu, Nov 20, 12:43 PM
Unknown Object (File)
Tue, Nov 18, 7:01 AM
Unknown Object (File)
Sun, Nov 16, 6:55 AM
Unknown Object (File)
Tue, Nov 4, 12:53 AM
Unknown Object (File)
Sun, Oct 26, 4:26 PM
Unknown Object (File)
Oct 22 2025, 6:21 AM
Unknown Object (File)
Oct 21 2025, 1:16 PM
Unknown Object (File)
Oct 20 2025, 10:26 PM
View All Files
Subscribers
imp

Details

Reviewers
cognet
sbruno
adrian
Commits
rS303413: [iwm] Fix inverted logic in iwm_tx().
Summary
The PROT_REQUIRE flag in should be set for data frames above a certain
length, but we were setting it for !data frames above a certain length,
which makes no sense at all.

Taken-From: OpenBSD, Linux iwlwifi

Obtained from: DragonFlyBSD git 8cc03924a36c572c2908e659e624f44636dc2b33

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivadasz updated this revision to Diff 18777.Jul 26 2016, 9:44 PM
ivadasz retitled this revision from to [iwm] Fix inverted logic in iwm_tx()..
ivadasz updated this object.
ivadasz edited the test plan for this revision. (Show Details)
ivadasz added reviewers: adrian, cognet, sbruno.
Herald added a subscriber: imp. · View Herald TranscriptJul 26 2016, 9:44 PM
adrian accepted this revision.Jul 26 2016, 10:20 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 10:20 PM
Closed by commit rS303413: [iwm] Fix inverted logic in iwm_tx(). (authored by ivadasz). · Explain WhyJul 27 2016, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwm/
2 lines

Diff 18824

View Options

head/sys/dev/iwm/if_iwm.c

Loading...