Use MTX_SYSINIT for the VESA lock.
ClosedPublic
Actions

Authored by jhb on Jul 22 2016, 9:31 PM.

Details

Reviewers

dumbbell
royger

Commits

rS303225: Use MTX_SYSINIT for the VESA lock.

Summary

Use MTX_SYSINIT for the VESA lock.

vesa_init_done isn't a reliable guard for the mutex init. If
vesa_configure() doesn't find valid VESA info it will not set
vesa_init_done, but the lock will remain initialized. Revert r303076
and use MTX_SYSINIT to deterministically init the lock.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 18689.Jul 22 2016, 9:31 PM

jhb retitled this revision from to Use MTX_SYSINIT for the VESA lock..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: royger, dumbbell.

Herald added a subscriber: imp. · View Herald TranscriptJul 22 2016, 9:31 PM

Don't explicitly destroy the lock.

I cannot test this ATM (I might be able to do it tomorrow), but it looks fine, and AFAICT it should also solve the issue I was seeing. Thanks for taking care of this (and sorry for messing it up)!

This revision is now accepted and ready to land.Jul 23 2016, 9:43 AM

Oh, forgot to ask, but since I'm not going to MFC r303076 could you please MFC this to stable/11?

Thanks.

Closed by commit rS303225: Use MTX_SYSINIT for the VESA lock. (authored by jhb). · Explain WhyJul 23 2016, 2:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

fb/

vesa.c

20 lines

Diff 18699

View Options

Use MTX_SYSINIT for the VESA lock.ClosedPublicActions