Switch to linker sets to find the xport callback object.
ClosedPublic
Actions

Authored by imp on Jul 22 2016, 8:09 PM.

Details

Reviewers

scottl
ken
mav

Commits

rS303468: Move protocol specific stuff into a linker set object that's
rS303467: Switch to linker sets to find the xport callback object. This

Summary

Switch to linker sets to find the xport callback object. This
eliminates the need to special case everything in cam_xpt for new
transports. It is now a failure to not have a transport object when
registering the bus as well.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp updated this revision to Diff 18684.Jul 22 2016, 8:09 PM

imp retitled this revision from to Switch to linker sets to find the xport callback object..

imp updated this object.

imp edited the test plan for this revision. (Show Details)

imp added reviewers: scottl, ken, mav.Jul 22 2016, 8:10 PM

Switch to linker sets to find the xport callback object. This
Include NVMe transport and direct access devices on amd64.
Switch to linker sets to find the protocol callback object.

chuck_tuffli.net added a subscriber: chuck_tuffli.net.Jul 22 2016, 9:14 PM

chuck_tuffli.net added inline comments.

sys/cam/cam_xpt.c
3915 ↗	(On Diff #18685)	Won't this behave differently compared to the original? Should this be new_bus->xport = &xport_default; ?

imp added inline comments.Jul 24 2016, 5:31 PM

sys/cam/cam_xpt.c
3915 ↗	(On Diff #18685)	That assignment was never needed, since it was redundant after line 3889 (new file numbering). It also underscores that fact that you're no longer allowed to create a transport of an unknown / unspecified type.