Differential D7187

Remove redundant declaration for tcp_dooptions
ClosedPublic
Actions

Authored by ngie on Jul 11 2016, 3:27 PM.

Details

Reviewers

Summary

Remove redundant declaration for tcp_dooptions

netinet/tcp_var.h already defines this function

PR: 209924
Reported by: Mark Millard <markmi@dsl-only.net>
Sponsored by: EMC / Isilon Storage Division

Test Plan

make buildkernel passed
TODO: make tinderbox (mostly concerned with the INET vs NOINET variations of kernels)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4479
Build 4530: arc lint + arc unit

Event Timeline

ngie updated this revision to Diff 18286.Jul 11 2016, 3:27 PM

ngie retitled this revision from to Remove redundant declaration for tcp_dooptions.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: np.

Herald added a subscriber: imp. · View Herald TranscriptJul 11 2016, 3:27 PM

I'm ok with this if it compiles with the default compiler and settings. The PR number in the commit log should be 209920 and not 209924.

This revision is now accepted and ready to land.Jul 11 2016, 4:46 PM

In D7187#149392, @np wrote:

I'm ok with this if it compiles with the default compiler and settings. The PR number in the commit log should be 209920 and not 209924.

Ok. I've verified that it works with clang 3.8.0, gcc 4.2.1, and gcc 5.3.0.

Thanks for fixing the PR # :).

rS302576

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgb/

ulp/

tom/

cxgb_listen.c

3 lines

Diff 18286

View Options

sys/dev/cxgb/ulp/tom/cxgb_listen.c

Remove redundant declaration for tcp_dooptionsClosedPublicActions