Include command line arguments in core dump process info.
Fill in pr_psargs in the NT_PRSINFO ELF core dump note with command
line arguments.
Details
Details
- Reviewers
kib emaste - Commits
- rS302859: Include command line arguments in core dump process info.
- generate core dumps with the change and open them in gdb
- was not able to test lldb as lldb doesn't examine NT_PRSINFO on FreeBSD at all (and it uses the Linux PRSTATUS parser on FreeBSD cores which is wrong. Fixing lldb means writing ELF core note parsers for the FreeBSD core notes).
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/kern/imgact_elf.c | ||
|---|---|---|
| 1851 ↗ | (On Diff #18158) | I think this is too limiting. If p_args is NULL, you should use proc_getargv() to read the arguments from the process UVA directly. p_args is not guaranteed to exist. |
| sys/kern/imgact_elf.c | ||
|---|---|---|
| 1851 ↗ | (On Diff #18158) | Humm, I guess I could do that. Note that pr_psargs is only 80 chars long. One thing that is annoying about proc_get_argv() is that I'll need to change it to take a maxlength, but I can do that. (I guess I had assumed that this is less useful if you have a really long command line and that any short command lines should have a valid p_args) |
Comment Actions
- Use proc_getargv() if p_args is NULL.
- Set len in the proc_getargv() case to avoid trashing random memory.
- Fix 'len' when the sbuf overflows.