hyperv/vmbus: Fix the racy channel close.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jul 5 2016, 3:16 PM.

Tags

None

Referenced Files

	F170637384: D7112.id.diff
	Sat, Sep 5, 6:18 PM

	Unknown Object (File)
	Sat, Sep 5, 3:42 AM

	Unknown Object (File)
	Sat, Sep 5, 1:54 AM

	Unknown Object (File)
	Thu, Sep 3, 3:06 PM

	Unknown Object (File)
	Thu, Sep 3, 3:44 AM

	Unknown Object (File)
	Thu, Sep 3, 2:39 AM

	Unknown Object (File)
	Tue, Sep 1, 9:30 AM

	Unknown Object (File)
	Tue, Sep 1, 2:19 AM

View All Files

Subscribers

None

Details

Reviewers

howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger

Commits

rS302818: hyperv/vmbus: Fix the racy channel close.

Summary

It is not safe to iterate the sub-channel list w/o lock on the
close path, while it's even more difficult to hold the lock
and iterate the sub-channel list.  We leverage the
vmbua_{get,rel}_subchan() functions to solve this dilemma.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 18150.Jul 5 2016, 3:16 PM

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Fix the racy channel close..

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.

Closed by commit rS302818: hyperv/vmbus: Fix the racy channel close. (authored by sephe). · Explain WhyJul 14 2016, 7:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hyperv/

vmbus/

hv_channel.c

39 lines

Diff 18417

View Options

head/sys/dev/hyperv/vmbus/hv_channel.c

hyperv/vmbus: Fix the racy channel close.ClosedPublicActions